JDK-8203287 : Zero fails to build after JDK-8199712 (Flight Recorder)
  • Type: Bug
  • Component: hotspot
  • Sub-Component: runtime
  • Affected Version: openjdk8u-jfr-incubator
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2018-05-16
  • Updated: 2020-04-27
  • Resolved: 2018-05-18
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 11 Other
11 b15Fixed openjdk8u262Fixed
Related Reports
Duplicate :  
Relates :  
Relates :  
Description
1) ------------------------------------------------------ 

Building target 'images' in configuration 'linux-x86_64-normal-zero-fastdebug'
/home/shade/jdk-jdk/src/hotspot/share/jfr/periodic/sampling/jfrCallTrace.cpp: In member function 'bool JfrGetCallTrace::get_topframe(void*, frame&)':
/home/shade/jdk-jdk/src/hotspot/share/jfr/periodic/sampling/jfrCallTrace.cpp:99:17: error: 'class JavaThread' has no member named 'pd_get_top_frame_for_profiling'; did you mean 'pd_get_top_frame_for_signal_handler'?
   if (!_thread->pd_get_top_frame_for_profiling(&topframe, ucontext, _in_java)) {
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

2) ------------------------------------------------------ 

/home/shade/jdk-jdk/src/hotspot/share/jfr/utilities/jfrTime.cpp:29:25: fatal error: rdtsc_x86.hpp: No such file or directory
 #include "rdtsc_x86.hpp"
                         ^
compilation terminated.

3) ------------------------------------------------------

/home/shade/jdk-jdk/src/hotspot/os/linux/os_perf_linux.cpp:33:34: fatal error: vm_version_ext_x86.hpp: No such file or directory
 #include "vm_version_ext_x86.hpp"
                                  ^
compilation terminated.


Comments
Latest webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8203287/webrev.04/
18-05-2018

This fix now depends on the header changes in src/hotspot/os/linux/os_perf_linux.cpp of JDK-8203288.
17-05-2018

webrev which makes Zero build again: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8203287/webrev.01/
16-05-2018

Reassigned: sharing the fun with Severin.
16-05-2018

This patch fixes (1) and (2): http://cr.openjdk.java.net/~shade/8203287/partial.patch ...but (3) requires more thinking.
16-05-2018