JDK-8188111 : [TEST BUG] Write Manual Tests for WebView DragAndDrop and CopyToClipboard
  • Type: Bug
  • Component: javafx
  • Sub-Component: web
  • Affected Version: 10
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2017-09-28
  • Updated: 2017-10-26
  • Resolved: 2017-10-24
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 10
10Fixed
Related Reports
Relates :  
Relates :  
Relates :  
Relates :  
Description
Add Manual Test Case for verification of 
- content type added to clipboard on Drag and Drop  operation
- content type added to clipboard on `Copy To Clipboard` of image operation of context menu

Comments
Changeset: 74aa93001309 Author: rkamath Date: 2017-10-24 20:54 +0530 URL: http://hg.openjdk.java.net/openjfx/10-dev/tests/rev/74aa93001309
24-10-2017

+1
24-10-2017

+1
24-10-2017

+1
24-10-2017

[~ghb] Review comments incorporated. Please have a look at http://cr.openjdk.java.net/~ghb/rkamath/8188111/webrev.02/
24-10-2017

ClipboardContentLauncher.java --> Copyright (c) 2014, // update current year for boolean success = Clipboard.getSystemClipboard().hasString() && 96 !Clipboard.getSystemClipboard().hasFiles(); 97 if (success) { Keep the condition inside if statement. make these local as final WebView webView = new WebView(); Label textLabel = new Label("Drag Text Here"); Remove 'private Document document = null;'' as its used only in the scope of "initializeResources" Remove 'private Label imageLabel = null;' its scope is only limited to 'createScene' Please remove un-used imports.
23-10-2017

Updated webrev after handling below review comments http://cr.openjdk.java.net/~ghb/rkamath/8188111/webrev.01/ 1. Remove the additional html text for drag and drop test case - Done 2. Use gif from existing source.Dont add additional file - Done 3. Add previous button as well - Made existing button wrap over to start image instead of additional button 4. Change class scope variables to function scope if applicable. Change names of few variables. - Done 5. Make constants instead of hardcoding UI control size values - Done 6. Make pre-increment instead of post-increment - Done 7. Use lamda functions whererver applicable - Done 8. Use OpenJDK alias instead of fullname in author - Done 9. Declaration and definition can be clubbed at few places - Done
20-10-2017

WebRev for review: http://cr.openjdk.java.net/~ghb/rkamath/8188111/webrev.00/ Added manual tests for the mentioned scenarios. Tested with and without patch. Please note that i have also added test for JDK-8187928 which are failing now but expected to pass after fix.
16-10-2017