JDK-8157295 : Encapsulate impl_ methods in Scene and KeyValue classes
Type:Enhancement
Component:javafx
Sub-Component:graphics
Affected Version:9
Priority:P3
Status:Resolved
Resolution:Fixed
Submitted:2016-05-19
Updated:2021-07-10
Resolved:2016-05-19
The Version table provides details related to the release that this issue/RFE will be addressed.
Unresolved : Release in which this issue/RFE will be addressed. Resolved: Release in which this issue/RFE has been resolved. Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.
Looks good.
A couple minor comments (no need for a new webrev if you decide to fix them).
1. In Node.java, the following could be called directly, since it is in the same package:
SceneHelper.setAllowPGAccess(true);
...
SceneHelper.setAllowPGAccess(false);
2. You have 3 extra blank lines at the end of KeyValueType.java.
+1
19-05-2016
Please review the proposed fix:
http://cr.openjdk.java.net/~ckyang/JDK-8157295/webrev.00/