JDK-8154509 : Remove the word impl_ in the name of private and package scope methods and fields
  • Type: Enhancement
  • Component: javafx
  • Sub-Component: graphics
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2016-04-19
  • Updated: 2016-04-21
  • Resolved: 2016-04-21
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Related Reports
Blocks :  
We would like to remove the word impl_ in the name of all private methods and members. This will make the implementation and review of JDK-8144585 easier: 

./modules/graphics/src/main/java/javafx/scene/effect/FloatMap.java:    private void impl_update() {
./modules/graphics/src/main/java/javafx/scene/effect/FloatMap.java:    private void impl_markDirty() {
./modules/graphics/src/main/java/javafx/scene/effect/FloatMap.java:    private void impl_clearDirty() {
./modules/graphics/src/main/java/javafx/scene/image/Image.java:    private final InputStream impl_source;
./modules/graphics/src/main/java/javafx/scene/Node.java:    private double impl_computeAreaInScreen() {
./modules/graphics/src/main/java/javafx/scene/Node.java:    private BooleanProperty impl_showMnemonics;
./modules/graphics/src/main/java/javafx/scene/Parent.java:    private javafx.beans.property.ObjectProperty<ParentTraversalEngine> impl_traversalEngine;
./modules/graphics/src/main/java/javafx/scene/Scene.java:    private TKScene impl_peer;
./modules/graphics/src/main/java/javafx/scene/shape/Path.java:    private boolean impl_isFirstPathElementValid() {
./modules/graphics/src/main/java/javafx/scene/text/Text.java:        private ObjectProperty<PathElement[]> impl_selectionShape;
./modules/graphics/src/main/java/javafx/scene/text/Text.java:        private ObjectBinding<PathElement[]> impl_selectionBinding;
./modules/graphics/src/main/java/javafx/scene/text/Text.java:        private IntegerProperty impl_selectionStart;
./modules/graphics/src/main/java/javafx/scene/text/Text.java:        private IntegerProperty impl_selectionEnd;
./modules/graphics/src/main/java/javafx/scene/text/Text.java:        private ObjectProperty<PathElement[]> impl_caretShape;
./modules/graphics/src/main/java/javafx/scene/text/Text.java:        private ObjectBinding<PathElement[]> impl_caretBinding;
./modules/graphics/src/main/java/javafx/scene/text/Text.java:        private IntegerProperty impl_caretPosition;
./modules/graphics/src/main/java/javafx/scene/text/Text.java:        private BooleanProperty impl_caretBias;
./modules/graphics/src/main/java/javafx/scene/transform/Transform.java:    private WeakReferenceQueue impl_nodes = new WeakReferenceQueue();
Changeset: 903a7850775e Author: ckyang Date: 2016-04-21 09:07 -0700 URL: http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/903a7850775e


Here is webrev v2: http://cr.openjdk.java.net/~ckyang/JDK-8154509/webrev.01/

OK. I will include package scope methods and members in the next webrev.

It all looks fine to me, although I still would like to build and test tomorrow. I noticed the following in Image.java: final InputStream getImpl_source() I know this isn't private, but you could (and eventually need to) remove impl_ from package-scope methods, too. It might be better to do both private and pacakge-scope at the same time.

Please review this simple name change of private methods and members (excluding properties) to not use impl_: webrev: http://cr.openjdk.java.net/~ckyang/JDK-8154509/webrev.00/

We shouldn't do this for the ones that are actually properties, since by convention they need to match the name of the property. The others will be good to cleanup.