JDK-8079362 : Enforce best practices for Node token API usage
- Type: Task
- Component: core-libs
- Sub-Component: jdk.nashorn
- Affected Version: 9
- Priority: P4
- Status: Resolved
- Resolution: Fixed
- OS: generic
- CPU: generic
- Submitted: 2015-05-05
- Updated: 2015-09-29
- Resolved: 2015-05-06
The Version table provides details related to the release that this issue/RFE will be addressed.
Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.
To download the current JDK release, click here.
Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.
To download the current JDK release, click here.
| JDK 8 | JDK 9 |
|---|---|
8u60Fixed  |
9 b64Fixed |
Description
Nashorn's Node class has both a "TokenType tokenType()" method and a "boolean isTokenType(TokenType)" method, and often we can see expressions of form "node.tokenType() == <tokenType>" that could be consistently replaced with "node.isTokenType(<tokenType>). There's also some weird roundabout usage of "Token.descType(node.getToken())" in places which should simply by "node.tokenType()". No big deal, but API usage consistency is nice to have for clarity.