JDK-8072375 : LangTools: Investigate versioning impact to launcher (source, tests, etc.)
  • Type: Sub-task
  • Component: tools
  • Sub-Component: launcher
  • Affected Version: 9
  • Priority: P4
  • Status: Resolved
  • Resolution: Not an Issue
  • Submitted: 2015-02-03
  • Updated: 2015-02-13
  • Resolved: 2015-02-13
Related Reports
Relates :  
JDK-8050071 - JEP 231: Remove Launch-Time JRE Version Selection
Description
Now that support for mJRE has been withdrawn from JDK 9 (JEP 231: Remove Launch-Time JRE Version Selection, JDK-8050071), there should be no further impact to the launcher source.  However, it would be prudent to verify this. Some regression tests and the Win Registry lookup are potentially affected.
Comments
used this patch to update the version: diff --git a/common/autoconf/version-numbers b/common/autoconf/version-numbers --- a/common/autoconf/version-numbers +++ b/common/autoconf/version-numbers @@ -23,8 +23,8 @@ # questions. # -JDK_MAJOR_VERSION=1 -JDK_MINOR_VERSION=9 +JDK_MAJOR_VERSION=9 +JDK_MINOR_VERSION=0 JDK_MICRO_VERSION=0 JDK_UPDATE_VERSION= LAUNCHER_NAME=openjdk
13-02-2015
Closed as NAI, will need bugs to adjust tests when the changes are actually implemented.
13-02-2015
if the tool versions see JDK-8072376, the test jdk/test/tools/launcher/VersionCheck.java may need adjustments.
13-02-2015
In order to understand the implications of the version change I made a few changes on Windows to get this: % java -version openjdk version "9.0.0-internal" OpenJDK Runtime Environment (build 9.0.0-internal-deleted_2015_02_10_06_45-b00) OpenJDK 64-Bit Server VM (build 9.0.0-internal-deleted_2015_02_10_06_45-b00, mixed mode) Note that the major version = 9, minor = 0, micro = 0 All the regression tests pass. The minor nit here is that on Windows the launcher (java.exe) can be separated from the JAVA_HOME and placed in system directories, this was to achieve symlinks from system directories to the installation directory, for instance on Unix /bin/java -> /usr/jdk/instances/jdk9/bin/java Thus for the separated java executable say in $SYSTEMDIR/System/java.exe to locate jvm.dll, the java.exe interrogates the Windows registry, by using the version number baked into the launcher with the registry entries. Tested this by modifying the Windows registry by ie. Setting the following: HKLM/SOFTWARE/JavaSoft/CurrentVersion=9.0 HKLM/SOFTWARE/JavaSoft JavaHome=/path_to_jdk9.0/ RuntimeLib=/path_to_jdk9.0/server/jvm.dll In conclusion I do not foresee any issues at this time.
10-02-2015