JDK-8000592 : Improve adlc usability
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: compiler
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • OS: generic
  • CPU: generic
  • Submitted: 2012-10-08
  • Updated: 2014-02-05
  • Resolved: 2012-10-17
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 7 JDK 8 Other
7u40Fixed 8 b61Fixed hs24Fixed
We did a row of smaller changes to adlc to improve its usability, e.g.

- Make adlc more stable, especially if parsing faulty .ad files.
- In some cases raise syntax errors instead of asserting.
- Write more comments into generated files and beautify format.
- Make calls to node->format() more stable.
- Clean up adlc code: warnings, dead code etc.

Notice that all these changes shouldn't affect the generated code in any way!

I collected all these and put them into this webrev:


We would like to contribute this to the openJDK.  Could somebody
please review the change and push it if it seems useful to you?

Thanks a lot,
We already have fixed subcr (backport) for HS25 created by JPRT/JIRA when I pushed changes. Keep version "8" in this report so that is will be marked fixed after these changes promoted into jdk8.