JDK-7152961 : InlineTree::should_not_inline may exit prematurely
  • Type: Bug
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: hs24
  • Priority: P5
  • Status: Resolved
  • Resolution: Fixed
  • OS: generic
  • CPU: generic
  • Submitted: 2012-03-12
  • Updated: 2013-06-26
  • Resolved: 2012-03-24
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 7 JDK 8 Other
7u40Fixed 8Fixed hs24Fixed
Description
InlineTree::should_not_inline may exit prematurely.

In the middle of InlineTree::should_not_inline there is a check that makes trivial sized method return NULL/false early. 

"// use frequency-based objections only for non-trivial methods"

So any relevant clause after will never be run for many very small methods. One effect is that compilerOracle dont-inline commands are not always respected. This does not seem to be the intention.

Moving compilerOracle and string cache heuristics above that check, leaving the clauses that actually depend on frequency/profiling in place.
Comments
EVALUATION http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0f4014d7731b
28-03-2012
EVALUATION http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/0f4014d7731b
13-03-2012
EVALUATION See description
12-03-2012