JDK-7130334 : G1: Change comments and error messages that refer to CMS in g1/concurrentMark.cpp/hpp
  • Type: Bug
  • Component: hotspot
  • Sub-Component: gc
  • Affected Version: hs23
  • Priority: P4
  • Status: Closed
  • Resolution: Fixed
  • OS: generic
  • CPU: generic
  • Submitted: 2012-01-16
  • Updated: 2013-09-18
  • Resolved: 2012-03-24
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 7 JDK 8 Other
7u4Fixed 8Fixed hs23Fixed
The files g1/concurrentMark.cpp and g1/concurrentMark.hpp have comments and error messages that refer to CMS. Particularly the error messages are unfortunate since they can be user visible. We should update thes comments and messages.

Did a "grep -R -i CMS src/share/vm/gc_implementation/g1". concurrentMark.cpp/hpp seem to be the only files that have this issue. The other files mention CMS in a correct way:

src/share/vm/gc_implementation/g1/concurrentMark.cpp:// CMS Bit Map Wrapper
src/share/vm/gc_implementation/g1/concurrentMark.cpp:  guarantee(brs.is_reserved(), "couldn't allocate CMS bit map");
src/share/vm/gc_implementation/g1/concurrentMark.cpp:            "couldn't reseve backing store for CMS bit map");
src/share/vm/gc_implementation/g1/concurrentMark.cpp:         "didn't reserve backing store for all of CMS bit map?");
src/share/vm/gc_implementation/g1/concurrentMark.cpp:    // the ones in CMS generation.
src/share/vm/gc_implementation/g1/concurrentMark.cpp:// from external roots in the CMS bit map.
src/share/vm/gc_implementation/g1/concurrentMark.cpp:// This closure is used to mark refs into the CMS generation in
src/share/vm/gc_implementation/g1/concurrentMark.cpp:// the CMS bit map. Called at the first checkpoint.
src/share/vm/gc_implementation/g1/concurrentMark.hpp:  // CMS marking support structures
src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp:// Note: As is the case with CMS - this method, although exported
src/share/vm/gc_implementation/g1/g1BlockOffsetTable.inline.hpp:      // CMS-specific note: a block abutting _unallocated_block to
src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp:  // have been elided. G1, like CMS, allows this, but should be
src/share/vm/gc_implementation/g1/vm_operations_g1.cpp:      // The following is largely copied from CMS
src/share/vm/gc_implementation/g1/vm_operations_g1.hpp:// consider sharing these with CMS's counterparts.
src/share/vm/gc_implementation/g1/vm_operations_g1.hpp:  VM_CGC_Operation(VoidClosure* cl, const char *printGCMsg)
src/share/vm/gc_implementation/g1/vm_operations_g1.hpp:    : _cl(cl), _printGCMessage(printGCMsg) { }

EVALUATION http://hg.openjdk.java.net/lambda/lambda/hotspot/rev/851b58c26def

EVALUATION http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/851b58c26def