JDK-6941224 : Improved stack overflow handling for Zero
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: runtime
  • Affected Version: hs18
  • Priority: P4
  • Status: Closed
  • Resolution: Fixed
  • OS: generic
  • CPU: generic
  • Submitted: 2010-04-06
  • Updated: 2012-10-13
  • Resolved: 2010-05-05
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 6 JDK 7 Other
6u21pFixed 7Fixed hs18Fixed
Related Reports
Relates :  
Description
Gary Benson wrote:

Hi all,

I recently started adding stack overflow checking to Shark,
which brought to light a bunch of deficiencies in Zero's
stack overflow code.  Zero had this really odd, look-ahead
overflow handling which was pretty strange, easily fooled,
and in retrospect totally unnecessary.  I'm pretty sure
whoever wrote it was an idiot.

This webrev removes the old overflow detection and replaces
it with something more straightforward and complete:

  http://cr.openjdk.java.net/~gbenson/zero-stack-overflow-checks/

Note that a number of calls to Unimplemented have been removed.
It shouldn't be possible to have an unhandled stack overflow
error with the new code.

As a bonus, the new code is mildly faster (about 2%) due to
the checks being inlined.

I don't have a bug id for this.

Cheers,
Gary

Comments
EVALUATION http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/f9271ff9d324
16-04-2010