JDK-6876584 : parameters order is incorrect for enc_String_Equals() in x86_32.ad
  • Type: Bug
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: hs16
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • OS: solaris
  • CPU: x86
  • Submitted: 2009-08-27
  • Updated: 2010-04-03
  • Resolved: 2009-09-09
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 6 Other
6u18Fixed hs16Fixed
In instruction string_equals()
   ins_encode( enc_String_Equals(tmp1, tmp2, str1, str2, tmp3, tmp4, result) );

but declaration 
  enc_class enc_String_Equals(eDIRegP str1, eSIRegP str2, regXD tmp1, regXD tmp2,
                       eBXRegI tmp3, eCXRegI tmp4, eAXRegI result) %{

EVALUATION http://hg.openjdk.java.net/hsx/hsx16/master/rev/74453a25211d

PUBLIC COMMENTS Fixed parameters order for enc_String_Equals(), I forgot to fix it in 6875866. Fixed typo in the comments in 6875866 changes. Used shrq/addq in enc_String_IndexOf() in x86_64.ad to be consistent with following code. Added required /othervm to the 6875866 test.

EVALUATION http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/74453a25211d