JDK-6677629 : PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist()
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: hs12
  • Priority: P5
  • Status: Closed
  • Resolution: Fixed
  • OS: solaris_10
  • CPU: sparc
  • Submitted: 2008-03-19
  • Updated: 2011-04-23
  • Resolved: 2011-04-23
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 6 JDK 7 Other
6u21pFixed 7Fixed hs19Fixed
Description
C2 has a lot of places with the next calls sequence:

   add_users_to_worklist(old);
   hash_delete(old);
   subsume_node(old, nn);

and without add_users_to_worklist(old).

Investigate a possibility to call hash_delete() and add_users_to_worklist()
from subsume_node().

Comments
PUBLIC COMMENTS Currently C2 does not check that users of a subsumed node are placed on IGVN worklist. Because of that some expressions are not collapsed as expected. I suggest to use replace_node() method instead of subsume_node(). Make subsume_node() private and use it only in transform_old().
29-06-2010

EVALUATION http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/6027dddc26c6
29-06-2010