JDK-6617011 : additional changes needed for new PIP FilesInUse dialog
  • Type: Bug
  • Component: install
  • Sub-Component: install
  • Affected Version: 6u5
  • Priority: P3
  • Status: Closed
  • Resolution: Fixed
  • OS: generic,windows_xp
  • CPU: generic,x86
  • Submitted: 2007-10-15
  • Updated: 2010-09-17
  • Resolved: 2008-03-24
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
6u10 b13Fixed 7Fixed
6593761 is now completed, and the FilesInUse Dialog is working properly.  However, there are a few items that still need to be implemented:

-The listbox will have an all white background, rather than alternate shading.
-There is no i18n/l10n at this point.  It's all English for b06.
-It will show the .exe name, rather than the name of the actual application.
-ListBox items should not be selectable.

We'll need to address this in a later 6uN build.

Also, "Quit the applications listed" is checked by default.

The spec does say unchecked:

Bill says it should be just a 1 line change.
Webrev/test cases are out and accepted for the required code changes.  In addition to the enhancements listed in this CR, the changes also:

1. Introduced a horizontal scroll bar in the event window titles exceed the real estate provided in the listbox (scaled dynamically).
2. Added sorting to listbox contents (alphabetical).
webrev: http://sa.sfbay.sun.com/projects/deployment_data/6u10/6617011.1

EVALUATION Upon further review it makes sense to re-open the jusched/jucheck CR, and re-evaluate this one for the original enhancements. The jusched/jucheck CR will be addressed in b14.

EVALUATION There was another CR that got piggy-backed onto this one regarding jusched and jucheck (see above). This is the reason this CR failed during verification. Instead of re-opening the CR that was closed as a duplicate of this one, I'll just fix the jusched and jucheck issue along with the other enhancements already implemented.

EVALUATION If the locked executable name is either jusched.exe or jucheck.exe, we should just ignore it and not show it in the ListBox...and let the user continue. These are known java update processes, that the next update msi will automatically shutdown.

EVALUATION There are now 3 things that need to be done for this bug: 1. It should show the name of the actual application, rather than the .exe name. This should be retrieved from either the title of the dialog of the application, or the ProductName of the dll/exe that is running the process. We should go with the industry standard, whatever that is. 2. The ListBox items should not be selectable. This just involves using LBS_NOSEL for the listbox control in jinstall.rc. 3. The checkbox should be unchecked by default, rather than checked. This just involves removing these 2 lines from deploy/src/plugin/win32/jinstall/win32/FilesInUse.cpp: //make sure checkbox is checked by default CheckDlgButton(IDC_FILESINUSE_CHECKBOX, BST_CHECKED);

EVALUATION Here's what needed to be done: 1. The listbox should have alternate shading for items. 2. i18n work needs to be done 3. It should show the name of the actual application, rather than the .exe name 4. ListBox items should not be selectable. We've decided that #1 is not necessary, because the items are not selectable anyways. Rajani already implemented #2 with her fix for 6612115. So all that needs to be done is #3 and #4. I believe #4 just involves using LBS_NOSEL for the listbox control in jinstall.rc.