JDK-5070991 : 1.5.0 Regression: Focus is not changed when tab key is pressed in Automatic Prox
  • Type: Bug
  • Component: client-libs
  • Sub-Component: java.awt
  • Affected Version: 6
  • Priority: P3
  • Status: Closed
  • Resolution: Fixed
  • OS: windows_xp
  • CPU: x86
  • Submitted: 2004-07-02
  • Updated: 2014-08-21
  • Resolved: 2005-09-07
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other JDK 6
5.0u8Fixed 6 b51Fixed
Related Reports
Relates :  
JDK-6227508 - REGRESSION: Tab key dosnt allways work
Relates :  
JDK-6214603 - LayoutFocusTraversalPolicy;JDK1.5;wrong getComponentAfter()| JDK1.4 is OK.
Relates :  
JDK-8055750 - problem with LayoutComparator / SortingFocusTraversalPolicy
Relates :  
JDK-6923200 - swing LayoutComparator breaks transitivity that may lead to IllegalArgumentException
Relates :  
JDK-4928214 - Getting focus inside JInternalFrame which don't have focus
Description
Bug Description:
----------------
Focus is not changed when tab key is pressed in Automatic Proxy configuration Script textbox in JavaControl Panel.
This bug is reproducible only in Windows XP Professional with Classic Theme

JDK-Info:
---------
java version "1.5.0-beta3"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0-beta3-b57)
Java HotSpot(TM) Client VM (build 1.5.0-beta3-b57, mixed mode, sharing)

System-Info:
------------
OS Name	Microsoft Windows XP Home Edition
Version	5.1.2600 Service Pack 1 Build 2600
OS Manufacturer	Microsoft Corporation
System Name	SURESHCHANDAR
System Manufacturer	INTEL_
System Model	D845GBV2
System Type	X86-based PC
Processor	x86 Family 15 Model 2 Stepping 7 GenuineIntel ~2400 Mhz
BIOS Version/Date	Intel Corp. RG84510A.86A.0019.P11.0210211745, 10/21/2002
SMBIOS Version	2.3
Windows Directory	C:\WINDOWS
System Directory	C:\WINDOWS\System32
Boot Device	\Device\HarddiskVolume1
Locale	United States
Hardware Abstraction Layer	Version = "5.1.2600.1106 (xpsp1.020828-1920)"
User Name	SURESHCHANDAR\suresh
Time Zone	India Standard Time
Total Physical Memory	512.00 MB
Available Physical Memory	304.43 MB
Total Virtual Memory	1.72 GB
Available Virtual Memory	1.15 GB
Page File Space	1.22 GB
Page File	C:\pagefile.sys

Steps to Reproduce:
-------------------
Steps to Reproduce:

1. Change the theme of testing windows XP Professional P.C to Windows Classic.
2. Install jre1.5.0 b57
3. Invoke JavaControl Panel from command line(javacpl.exe)
4. Click "NetWork Setting" button in General tab.
5. In "Network Setting" window select "Use Automatic Proxy Setting Script" radio button.
6. Click tab key the focus will be in text field,click tab again the focus will not shift to next component.

the same steps works in windows XP Professional with Windows XP theme. 


###@###.### 2004-07-02
Comments
EVALUATION The solution may be to try simple search if the component wasn't found. In this case we would work around the possible transitivity problem.
23-08-2005
SUGGESTED FIX ------- SortingFocusTraversalPolicy.java ------- *** /tmp/sccs._Da4m2 ��L ��+�� 23 11:55:16 2005 --- SortingFocusTraversalPolicy.java ��L ��+�� 23 11:54:02 2005 *************** *** 250,264 **** if (log.isLoggable(Level.FINE)) log.fine("### Didn't find component " + aComponent.getName() + " in a cycle " + aContainer.getName()); return getFirstComponent(aContainer); } if (index < 0) { ! // If we're not in the cycle, then binarySearch returns ! // (-(insertion point) - 1). The next element is our insertion ! // point. ! index = -index - 2; } Component defComp = (Component)defaults.get(new Integer(index)); if (defComp != null) { return defComp; --- 250,273 ---- if (log.isLoggable(Level.FINE)) log.fine("### Didn't find component " + aComponent.getName() + " in a cycle " + aContainer.getName()); return getFirstComponent(aContainer); } if (index < 0) { ! // Fix for 5070991. ! // A workaround for a transitivity problem caused by ROW_TOLERANCE, ! // because of that the component may be missed in the binary search. ! // Try to search it again directly. ! int i = cycle.indexOf(aComponent); ! if (i >= 0) { ! index = i; ! } else { ! // If we're not in the cycle, then binarySearch returns ! // (-(insertion point) - 1). The next element is our insertion ! // point. ! index = -index - 2; ! } } Component defComp = (Component)defaults.get(new Integer(index)); if (defComp != null) { return defComp;
23-08-2005
EVALUATION The problem described above breaks the binary search algorithm used in SortingFTP. When getComponentAfter(..) is called it tries to search the given component in the focus traversal cycle but due to the transitivity problem the component can't be found. Thus the traversal algorithm gets broken.
19-08-2005
CONVERTED DATA BugTraq+ Release Management Values COMMIT TO FIX: mustang
08-09-2004
EVALUATION I am able to reproduce the problem. I will look further into this issue. The work around for those who have to use keyboard to navigate is to use Shift+Tab to traverse focus in reverse direction. This way you can get to the component after the text field where focus gets stuck. While this is a rather annoying worka round, the problem is not critical to be fixed in Tiger. ###@###.### 2004-07-12 This bug really belongs to Java Control Panel. Reassign to java_deployment. ###@###.### 2004-07-26 This is a swing bug. It is easily reproducible on a smaller test case - attached to this bug report. If you run the test case with JRE 1.4.2 - focus traverses fine. If you run it with 1.5.0 - focus gets stuck on text field and can be accessed only if you are going backwards (traversing focus backwards). This is a regression in accessibility. One could probably create a test case when focus would get stuck in either direction (just mirror the layout in attached example, and stick more focusable components in the middle). Re-assigning to swing. This definitely needs to be fixed in mustang - it is a regression from 1.4.2. ###@###.### 2004-08-04 Very interesting bug. It seems that this bug is dependent on the layout. If I change the GUI layout slightly, the bug is no longer reproducible. I highly suspect that this results from rather large changes made recently by AWT to SortingFocusTraversalPolicy and LayoutFocusTraversalPolicy (4719336). ###@###.### 2004-08-04 The case of the problem is that LayoutComparator is not correct comparator :( The problem is that it uses ROW_TOPLERANCE and thus the order is not transitive. The same problem exists in all releases from 1.4. This particular tests work fine with 1.4 because another bug in traversal policy (which was fixed in tiger :) ###@###.### 2004-08-05 Name: at153223 Date: 09/07/2004 Yes, ROW_TOLERANCE conception used in LayoutComparator really leads to a transitivity problem. Let's illustrate this on the concrete example, the testcase attached. There we have a transitive relation formed by three components of 'autoScriptLocationPanel'. They are (with coordinates) javax.swing.Box.Filler (5,15), 'locationLabel' (30,7) and 'locationTextField' (90,5). The relations are as follows: Box.Filler is "row-tolerant" to 'locationLabel' thus Box.Filler > 'locationLabel' 'locationLabel' is "row-tolerant" to 'locationTextField' thus 'locationLabel' > 'locationTextField' And so due to transitivity the next statement should be true: Box.Filler > 'locationTextField'. But this is not the case. For LayoutComparator Box.Filler is not "row-tolerant" to 'locationTextField', and because of this, the relation between these two components is "<". All this results in that in 'SortingFocusTraversalPolicy.getComponentAfter' when a component after 'locationTextField' is being searched an incorrect index of the traversal cycle is calculated. The difficulty is that this problem caused by "ROW_TOLERANCE conception" is rather a tolerated error then a bug. We may try to find a workaround. For instance, not including potentially not focusable (or even not visible) components such that Box.Filler into a traversal cycle helps. But what problems it may raise and how to detect those not focusable (?) ###@###.### 09/07/2004 ======================================================================
07-09-2004
WORK AROUND Use setNextFocusableComponent(component) to explicitly set the focus. ###@###.### 2004-08-04
04-08-2004