United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
JDK-8006542 : JSR 292: the VM_RedefineClasses::append_entry() must support invokedynamic entry kinds

Details
Type:
Bug
Submit Date:
2013-01-17
Status:
Resolved
Updated Date:
2014-02-12
Project Name:
JDK
Resolved Date:
2013-02-02
Component:
hotspot
OS:
generic
Sub-Component:
jvmti
CPU:
generic
Priority:
P3
Resolution:
Fixed
Affected Versions:
7u60,8
Fixed Versions:
hs25 (b18)

Related Reports
Backport:
Backport:
Backport:
Backport:
Relates:

Sub Tasks

Description
The RedefineClasses merges constant pools in the VM_RedefineClasses::merge_constant_pools().
If an entry in new version of the class does not match an entry in the old version, it is appended
by the call to the append_entry() function.
This function must also support the invokedynamic kinds of entries:
  JVM_CONSTANT_MethodType
  JVM_CONSTANT_MethodHandle
  JVM_CONSTANT_InvokeDynamic



                                    

Comments
I have a fix for that issue.
                                     
2013-01-17
URL:   http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9bf5f643d1cf
User:  minqi
Date:  2013-02-02 03:32:34 +0000

                                     
2013-02-02
URL:   http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/9bf5f643d1cf
User:  amurillo
Date:  2013-02-08 19:17:42 +0000

                                     
2013-02-08
The list of failed tests:
vm/mlvm/indy/func/jvmti/mergeCP_indy2manyDiff_a
vm/mlvm/indy/func/jvmti/mergeCP_indy2manyDiff_b
vm/mlvm/indy/func/jvmti/mergeCP_indy2manySame_a
vm/mlvm/indy/func/jvmti/mergeCP_indy2manySame_b
vm/mlvm/indy/func/jvmti/mergeCP_indy2none_a
vm/mlvm/indy/func/jvmti/mergeCP_indy2none_b
vm/mlvm/indy/func/jvmti/mergeCP_indy2same_a
vm/mlvm/indy/func/jvmti/mergeCP_indy2same_b
vm/mlvm/indy/func/jvmti/mergeCP_none2indy_a
vm/mlvm/indy/func/jvmti/mergeCP_none2indy_b 
                                     
2013-02-25
7u60-critical-request justification:

This bug fix is better to be in the release because it is a part of the JSR-292 support
in the JVMTI HotSwap API (includes RedefineClasses, RetransformClasses and PopFrame).

This bug is one of 12 bug fixes that depend on each other and must be integrated
in the order:
  https://jbs.oracle.com/bugs/browse/JDK-7194607
  https://jbs.oracle.com/bugs/browse/JDK-8005128
  https://jbs.oracle.com/bugs/browse/JDK-8006542
  https://jbs.oracle.com/bugs/browse/JDK-8006546
  https://jbs.oracle.com/bugs/browse/JDK-8006731
  https://jbs.oracle.com/bugs/browse/JDK-8008511
  https://jbs.oracle.com/bugs/browse/JDK-8007037
  https://jbs.oracle.com/bugs/browse/JDK-8014288
  https://jbs.oracle.com/bugs/browse/JDK-8013945
  https://jbs.oracle.com/bugs/browse/JDK-8014052
  https://jbs.oracle.com/bugs/browse/JDK-7187554
  https://jbs.oracle.com/bugs/browse/JDK-8023004

All the fixes above have been already integrated into the JDK 8
and tested in the hotspot-rt nightly for several months.

Risk: low
  The fixes touch the JVMTI HotSwap API that includes RedefineClasses, RetransformClasses and PopFrame.
  The risk is only to introduce regressions in this part of the JVMTI implementation.
  This impacts only the debugging and profiling tools that use the JVMTI HotSwap feature.
  There are very small chances for regressions to sneak into the class file
  constant pool processing and method handles implementation.

Webrevs and reviewers:
  The 7u60 webrevs location is:
    http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/2013/hotspot/7u_port/

  The fixes above were already passed the review process before integration
  into JDK 8. The reviewers were: twisti, jrose, coleenp, dholmes, etc.
  The 7u60 edition of fixes must be reviewed at least by jrose and twisti.

Level of effort:
  All fixes need a secondary review phase after rebase from jdk8 to 7u60 repository.

Testing coverage:
  The folllowing test suites must be run to ensure correctness of the fixes:
    JTREG tests: com/sun/jdi, java/lang/instrument
    NSK tests: vm.mlvm.testlist, nsk.jvmti.testlist, nsk.jdi.testlist, nsk.jdwp.testlist

Result of not integrating:
  The users will not be able to use HotSwap technology for debuging and profiling
  Java code that depends on the JSR-292 implementation.
  In that case the integration of these fixes will have to be requested/escalated
  in 7 updates by the tool vendors and/or customers.

                                     
2014-01-10



Hardware and Software, Engineered to Work Together