United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: JDK-6778493 Fix (langtools) ant build to honor fcs MILESTONE setting
JDK-6778493 : Fix (langtools) ant build to honor fcs MILESTONE setting

Details
Type:
Enhancement
Submit Date:
2008-12-01
Status:
Closed
Updated Date:
2011-05-18
Project Name:
JDK
Resolved Date:
2011-05-18
Component:
infrastructure
OS:
generic
Sub-Component:
build
CPU:
generic
Priority:
P4
Resolution:
Fixed
Affected Versions:
7
Fixed Versions:

Related Reports
Backport:

Sub Tasks

Description
(Description and Suggested Fix submitted by Mark Wielaard mark at klomp.org)
---------------------------

Hi,

The langtools now use a new ant based build Makefile. This new build
does not obey the setting of MILESTONE to the magic string "fcs" like
the rest of the build to get version strings without an -internal build
string marker. 

We use this feature in IcedTea to make sure the version strings of all
the tools are correct in releases (we additionally have some tweaks so
the version string can embed the hg tip node number and/or a distro
specific indicator).

Attached is a patch that fixes up the ant build Makefile to do the same
as the original Makefile-classic with respect to the release string when
MILESTONE is set to "fcs".

Cheers,

Mark

                                    

Comments
SUGGESTED FIX

--- openjdk/langtools/make/Makefile.orig
+++ openjdk/langtools/make/Makefile
@@ -82,7 +82,11 @@
 endif 
 
 ifdef MILESTONE
+ifneq ($(MILESTONE),fcs)
   ANT_OPTIONS += -Dmilestone=$(MILESTONE)
+else
+  ANT_OPTIONS += -Drelease=$(JDK_VERSION)
+endif
 endif
 
 ifdef BUILD_NUMBER
                                     
2008-12-01
EVALUATION

OK
                                     
2008-12-01



Hardware and Software, Engineered to Work Together