United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
JDK-6695777 : Queens.class should be built from source, not put in source repo

Details
Type:
Bug
Submit Date:
2008-04-29
Status:
Closed
Updated Date:
2012-10-08
Project Name:
JDK
Resolved Date:
2008-07-15
Component:
hotspot
OS:
generic
Sub-Component:
runtime
CPU:
generic
Priority:
P3
Resolution:
Fixed
Affected Versions:
7
Fixed Versions:
hs14 (b01)

Related Reports
Backport:
Backport:
Backport:
Backport:

Sub Tasks

Description
The files:
 hotspot/build/linux/Queens.class
 hotspot/build/solaris/Queens.class
are binary files and the source is readily available, they should be built from source instead of being added to the source repository.

Binary files in source repositories create legal issues and should be avoided.
See http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=147

                                    

Comments
SUGGESTED FIX

--- old/make/linux/makefiles/buildtree.make	Thu Jul  3 09:40:02 2008
+++ new/make/linux/makefiles/buildtree.make	Thu Jul  3 09:40:02 2008
@@ -328,7 +328,7 @@
 WRONG_DATA_MODE_MSG = \
 	echo "JAVA_HOME must point to $(DATA_MODE)bit JDK."
 
-test_gamma:  $(BUILDTREE_MAKE)
+test_gamma:  $(BUILDTREE_MAKE) $(GAMMADIR)/make/test/Queens.java
 	@echo Creating $@ ...
 	$(QUIETLY) ( \
 	echo '#!/bin/sh'; \
@@ -339,7 +339,8 @@
 	echo "then"; \
 	echo "  $(WRONG_DATA_MODE_MSG); exit 0;"; \
 	echo "fi"; \
-	echo 'CLASSPATH="$(GAMMADIR)/make/$(OS_FAMILY):$$CLASSPATH"'; \
+	echo "rm -f Queens.class"; \
+	echo "\$${JAVA_HOME}/bin/javac -d . $(GAMMADIR)/make/test/Queens.java"; \
 	echo '[ -f gamma_g ] && { gamma=gamma_g; }'; \
 	echo './$${gamma:-gamma} $(TESTFLAGS) Queens < /dev/null'; \
 	) > $@
--- old/make/solaris/makefiles/buildtree.make	Thu Jul  3 09:40:03 2008
+++ new/make/solaris/makefiles/buildtree.make	Thu Jul  3 09:40:03 2008
@@ -340,7 +340,7 @@
 WRONG_DATA_MODE_MSG = \
 	echo "JAVA_HOME must point to $(DATA_MODE)bit JDK."
 
-test_gamma:  $(BUILDTREE_MAKE)
+test_gamma:  $(BUILDTREE_MAKE) $(GAMMADIR)/make/test/Queens.java
 	@echo Creating $@ ...
 	$(QUIETLY) ( \
 	echo '#!/bin/ksh'; \
@@ -351,7 +351,8 @@
 	echo "then"; \
 	echo "  $(WRONG_DATA_MODE_MSG); exit 0;"; \
 	echo "fi"; \
-	echo 'CLASSPATH="$(GAMMADIR)/make/$(OS_FAMILY):$$CLASSPATH"'; \
+	echo "rm -f Queens.class"; \
+	echo "\$${JAVA_HOME}/bin/javac -d . $(GAMMADIR)/make/test/Queens.java"; \
 	echo '[ -f gamma_g ] && { gamma=gamma_g; }'; \
 	echo './$${gamma:-gamma} $(TESTFLAGS) Queens < /dev/null'; \
 	) > $@
Binary files old/make/linux/Queens.class and /tmp/dHWay_g differ
Binary files old/make/solaris/Queens.class and /tmp/dg6ayfh differ
                                     
2008-07-03
EVALUATION

http://hg.openjdk.java.net/jdk7/hotspot-svc/hotspot/rev/551f4309f476
                                     
2008-07-03
EVALUATION

Removing Queens.class files (2 of them) and creating the file on the fly with javac.
                                     
2008-07-03



Hardware and Software, Engineered to Work Together