JDK-6951923 : some uses of fatal1 were missed by 6888954
  • Type: Bug
  • Component: hotspot
  • Sub-Component: runtime
  • Affected Version: hs18
  • Priority: P4
  • Status: Closed
  • Resolution: Fixed
  • OS: generic
  • CPU: generic
  • Submitted: 2010-05-14
  • Updated: 2012-10-08
  • Resolved: 2010-05-18
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 6 JDK 7 Other
6u21pFixed 7Fixed hs19Fixed
Related Reports
Relates :  
JDK-6888954 - argument formatting for assert() and friends
Description
From: Gary Benson <###@###.###> 
To: ###@###.### 
Subject: Review Request: 6888954 broke Zero 
Date: Wed, 12 May 2010 17:44:31 +0100 
 
Hi all, 
 
The commit for 6888954 broke Zero.  This webrev fixes: 
 
  http://cr.openjdk.java.net/~gbenson/6888954-broke-zero/ 
 
I don't have a bug id for this. 
 
Cheers, 
Gary
Comments
SUGGESTED FIX --- old/hotspot/src/os_cpu/linux_zero/vm/os_linux_zero.cpp 2010-05-12 17:41:53.000000000 +0100 +++ new/hotspot/src/os_cpu/linux_zero/vm/os_linux_zero.cpp 2010-05-12 17:41:53.000000000 +0100 @@ -288,7 +288,7 @@ vm_exit_out_of_memory(0, "pthread_getattr_np"); } else { - fatal1("pthread_getattr_np failed with errno = %d", res); + fatal(err_msg("pthread_getattr_np failed with errno = %d", res)); } } @@ -296,7 +296,7 @@ size_t stack_bytes; res = pthread_attr_getstack(&attr, (void **) &stack_bottom, &stack_bytes); if (res != 0) { - fatal1("pthread_attr_getstack failed with errno = %d", res); + fatal(err_msg("pthread_attr_getstack failed with errno = %d", res)); } address stack_top = stack_bottom + stack_bytes; @@ -308,7 +308,7 @@ size_t guard_bytes; res = pthread_attr_getguardsize(&attr, &guard_bytes); if (res != 0) { - fatal1("pthread_attr_getguardsize failed with errno = %d", res); + fatal(err_msg("pthread_attr_getguardsize failed with errno = %d", res)); } int guard_pages = align_size_up(guard_bytes, page_bytes) / page_bytes; assert(guard_bytes == guard_pages * page_bytes, "unaligned guard");
14-05-2010
EVALUATION 6888954 removed the definition of fatal1, but uses still exist in os_linux_zero.cpp.
14-05-2010
EVALUATION http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/67d74f7a15d9
14-05-2010