United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: JDK-8011350 hgforest.sh can fail if sh is not bash
JDK-8011350 : hgforest.sh can fail if sh is not bash

Details
Type:
Bug
Submit Date:
2013-04-03
Status:
Closed
Updated Date:
2013-11-28
Project Name:
JDK
Resolved Date:
2013-04-04
Component:
infrastructure
OS:
generic
Sub-Component:
build
CPU:
generic
Priority:
P1
Resolution:
Fixed
Affected Versions:
Fixed Versions:

Related Reports

Sub Tasks

Description
Fixing JDK-8011342 revealed another occasional issue caused by evaluation of [ ] expressions involving -o or -a including !

hgforest.sh works fine if the sh shell is bash but may otherwise fail. 

The fix is to replace -a, -o and ! expressions with explicit test.
                                    

Comments
Should we just require bash? The new build already requires it.
                                     
2013-04-03
That's certainly the easiest option if bash is already required. I've also got a webrev ready which converts hgforest.sh to classic POSIX sh which was not fun.
                                     
2013-04-03
We would need to change get_source.sh to use bash to invoke hgforest.sh
                                     
2013-04-03
P1 to match 8011358
                                     
2013-04-03
URL:   http://hg.openjdk.java.net/jdk8/tl/rev/575f2ca947ab
User:  mduigou
Date:  2013-04-04 03:03:17 +0000

                                     
2013-04-04
URL:   http://hg.openjdk.java.net/jdk8/jdk8/rev/575f2ca947ab
User:  lana
Date:  2013-04-16 20:30:01 +0000

                                     
2013-04-16
Transitioned from Resolved to Closed / Not Verified on behalf of mikhail.kondratyev@oracle.com.
                                     
2013-11-28



Hardware and Software, Engineered to Work Together