United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
JDK-8007144 : Incremental inlining mistakes some call sites for dead ones and doesn't inline them

Details
Type:
Bug
Submit Date:
2013-01-30
Status:
Resolved
Updated Date:
2013-05-01
Project Name:
JDK
Resolved Date:
2013-02-05
Component:
hotspot
OS:
Sub-Component:
compiler
CPU:
Priority:
P4
Resolution:
Fixed
Affected Versions:
Fixed Versions:
hs25 (b18)

Related Reports
Backport:
Backport:
Backport:
Relates:

Sub Tasks

Description
Before incremental inlining inlines a new call site, it sanity checks the input state of the call node: if the call is in a part of the graph that is dead, there's no need to proceed with inlining and, the parser doesn't expect a strange input state anyway. One the check consists in testing the input edges to the call node that correspond to input arguments for top. Long/double arguments to a call are in 2 halves, one of which is top so incremental inlining will skip all calls with at least a long or double argument, mistaken them for dead calls.

This bug impacts the performance of the box2d test with nashorn (10-20% performance increase once fixed and LiveNodeCountInliningCutoff bumped to 30000).
                                    

Comments
See description for cause
                                     
2013-01-30
URL:   http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/8bd61471a109
User:  roland
Date:  2013-02-05 13:00:43 +0000

                                     
2013-02-05
URL:   http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/8bd61471a109
User:  amurillo
Date:  2013-02-08 19:17:42 +0000

                                     
2013-02-08



Hardware and Software, Engineered to Work Together