United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: JDK-8001756 Hotspot makefiles report missing OBJCOPY command in the wrong circumstances
JDK-8001756 : Hotspot makefiles report missing OBJCOPY command in the wrong circumstances

Details
Type:
Bug
Submit Date:
2012-10-29
Status:
Resolved
Updated Date:
2013-08-06
Project Name:
JDK
Resolved Date:
2012-11-06
Component:
hotspot
OS:
Sub-Component:
build
CPU:
Priority:
P4
Resolution:
Fixed
Affected Versions:
hs25
Fixed Versions:
hs25 (b09)

Related Reports
Backport:
Backport:
Backport:
Backport:
Backport:

Sub Tasks

Description
The Full Debug Symbol (FDS) makefile logic is as follows (<os>/makefiles/defs.make):

 ifeq ($(BUILD_FLAVOR), product)
    FULL_DEBUG_SYMBOLS ?= 1
    ENABLE_FULL_DEBUG_SYMBOLS = $(FULL_DEBUG_SYMBOLS)
  else
    # debug variants always get Full Debug Symbols (if available)
    ENABLE_FULL_DEBUG_SYMBOLS = 1
  endif
  _JUNK_ := $(shell \
    echo >&2 "INFO: ENABLE_FULL_DEBUG_SYMBOLS=$(ENABLE_FULL_DEBUG_SYMBOLS)")
  # since objcopy is optional, we set ZIP_DEBUGINFO_FILES later

  ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1)
   ...
  else
    OBJCOPY=
  endif

So if we have explicitly disabled FDS then OBJCOPY will be cleared by the above. However we then have:

  ifeq ($(OBJCOPY),)
    _JUNK_ := $(shell \
      echo >&2 "INFO: no objcopy cmd found so cannot create .debuginfo files.")
    ENABLE_FULL_DEBUG_SYMBOLS=0
    _JUNK_ := $(shell \
      echo >&2 "INFO: ENABLE_FULL_DEBUG_SYMBOLS=$(ENABLE_FULL_DEBUG_SYMBOLS)")

So we then erroneously (and noisily) report that OBJCOPY could not be found when in fact we never looked for it, and didn't need to.

The OBJCOPY logic should be folded into the preceding " ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1)" block.

                                    

Comments
URL:   http://hg.openjdk.java.net/hsx/hotspot-emb/hotspot/rev/f8c93c0753f0
User:  dholmes
Date:  2012-11-06 08:08:38 +0000

                                     
2012-11-06
URL:   http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/857f3ce858dd
User:  amurillo
Date:  2012-11-09 19:30:16 +0000

                                     
2012-11-09



Hardware and Software, Engineered to Work Together