United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: JDK-8000592 Improve adlc usability
JDK-8000592 : Improve adlc usability

Details
Type:
Enhancement
Submit Date:
2012-10-08
Status:
Resolved
Updated Date:
2014-02-05
Project Name:
JDK
Resolved Date:
2012-10-17
Component:
hotspot
OS:
generic
Sub-Component:
compiler
CPU:
generic
Priority:
P4
Resolution:
Fixed
Affected Versions:
Fixed Versions:

Related Reports
Backport:
Backport:
Backport:
Backport:
Backport:
Backport:

Sub Tasks

Description
We did a row of smaller changes to adlc to improve its usability, e.g.

- Make adlc more stable, especially if parsing faulty .ad files.
- In some cases raise syntax errors instead of asserting.
- Write more comments into generated files and beautify format.
- Make calls to node->format() more stable.
- Clean up adlc code: warnings, dead code etc.

Notice that all these changes shouldn't affect the generated code in any way!

I collected all these and put them into this webrev:

 http://cr.openjdk.java.net/~goetz/webrevs/webrev-adlc_usability/

We would like to contribute this to the openJDK.  Could somebody
please review the change and push it if it seems useful to you?

Thanks a lot,
  Goetz.
                                    

Comments
We already have fixed subcr (backport) for HS25 created by JPRT/JIRA when I pushed changes. Keep version "8" in this report so that is will be marked fixed after these changes promoted into jdk8.
                                     
2012-10-10
URL:   http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/d336b3173277
User:  amurillo
Date:  2012-10-17 20:23:59 +0000

                                     
2012-10-17



Hardware and Software, Engineered to Work Together