On 9/30/12 8:45 PM, John Rose wrote:
> I just noticed this code in loopTransform:
> // Use longs to avoid integer overflow.
> int stride_con = cl->stride_con();
> long init_con = cl->init_trip()->get_int();
> long limit_con = cl->limit()->get_int();
> int stride_m = stride_con - (stride_con> 0 ? 1 : -1);
> long trip_count = (limit_con - init_con + stride_m)/stride_con;
> (It has your name on it.) Don't you want jlong in such code instead of plain long?
> ??? John
Yes, you are absolutely right. Maybe we should redefine 'long' so that compilers will complain about its usage. We need to find all usages of naked long (which some C++ compilers treats as 32-bit value) and replace it with jlong (which is defined in Hotspot as always 64-bit value).