United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: JDK-7200163 add CodeComments functionality to assember stubs
JDK-7200163 : add CodeComments functionality to assember stubs

Details
Type:
Enhancement
Submit Date:
2012-09-21
Status:
Resolved
Updated Date:
2013-04-30
Project Name:
JDK
Resolved Date:
2012-09-24
Component:
hotspot
OS:
generic
Sub-Component:
compiler
CPU:
generic
Priority:
P4
Resolution:
Fixed
Affected Versions:
hs25
Fixed Versions:
hs25 (b03)

Related Reports
Backport:
Backport:
Backport:
Backport:
Backport:

Sub Tasks

Description
The Assembler and CodeBuffer classes supply CodeComment / block_comment() functionality, which does not work with stubs. The comments are not printed with +PrintStubCode or +PrintInterpreter because the comments are lost when the code is turned into a Stub, while they are kept if the code is copied to a CodeBlob.

I propose to add this fix to the OpenJDK mainline. A webrev can be found here:

http://cr.openjdk.java.net/~goetz/webrevs/webrev-comments_in_stubs/

Basically the change passes the codeBuffer to the Stub constructor, and adapts the disassembler to print the comments.

In the debug build the  InterpreterCodelet Stub has a new field holding the code comments.

I also added some ttyLocks and \\ns to beautify the output.

Thank you and best regards,

  Goetz

                                    

Comments
EVALUATION

http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/b31471cdc53e
                                     
2012-09-24
URL:   http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/b31471cdc53e
User:  kvn
Date:  2012-09-28 19:34:46 +0000

                                     
2012-09-28
URL:   http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/b31471cdc53e
User:  amurillo
Date:  2012-09-28 22:30:08 +0000

                                     
2012-09-28



Hardware and Software, Engineered to Work Together