United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: JDK-7170010 conditional "ZIP_DEBUGINFO_FILES ?= 0" setting is not reliable on Windows
JDK-7170010 : conditional "ZIP_DEBUGINFO_FILES ?= 0" setting is not reliable on Windows

Details
Type:
Bug
Submit Date:
2012-05-18
Status:
Resolved
Updated Date:
2013-07-19
Project Name:
JDK
Resolved Date:
2012-05-26
Component:
hotspot
OS:
windows
Sub-Component:
build
CPU:
generic
Priority:
P3
Resolution:
Fixed
Affected Versions:
hs24
Fixed Versions:
hs24 (b12)

Related Reports
Backport:
Backport:
Backport:
Backport:
Relates:

Sub Tasks

Description
My fix for the following bug:

    7169409 3/4 enabling ZIP_DEBUGINFO_FILES causes unexpected test
                failures on Windows X86

went thru the JPRT-hotspot west queue and the ZIP_DEBUGINFO_FILES
feature was disabled by default:

$ grep ZIP_DEBUGINFO_FILES 2012-05-16-194957.ddaugher.71
65060_for_hsx24/sourcetree/make/windows/makefiles/defs.make 
# The ZIP_DEBUGINFO_FILES option only has meaning when FDS is enabled.
  # Disable ZIP_DEBUGINFO_FILES by default because various tests are
  ZIP_DEBUGINFO_FILES ?= 0
  ZIP_DEBUGINFO_FILES=0
MAKE_ARGS += ZIP_DEBUGINFO_FILES=$(ZIP_DEBUGINFO_FILES)
    ifeq ($(ZIP_DEBUGINFO_FILES),1)
    ifeq ($(ZIP_DEBUGINFO_FILES),1)
    ifeq ($(ZIP_DEBUGINFO_FILES),1)
    ifeq ($(ZIP_DEBUGINFO_FILES),1)


$ grep ZIP_DEBUGINFO_FILES 2012-05-16-194957.ddaugher.7165060_for_hsx24/logs/windows_*_5*product.log
2012-05-16-194957.ddaugher.7165060_for_hsx24/logs/windows_i586_5.1-product.log:                ARCH=x86 BUILDARCH=i486 Platform_arch=x86 Platform_arch_model=x86_32 ARCH=x86 BUILDARCH=i486 Platform_arch=x86 Platform_arch_model=x86_32 ENABLE_FULL_DEBUG_SYMBOLS=1 ZIP_DEBUGINFO_FILES=0 RM="rm -f" ZIPEXE=zip JDK_MKTG_VERSION=8.0 JDK_MAJOR_VER=1 JDK_MINOR_VER=8 JDK_MICRO_VER=0 BUILD_WIN_SA=1 JAVA_HOME=C:\\jprt\\products\\P1\\jdk6u18-fcs\\jdk1.6.0_18 OUTPUTDIR=C:\\jprt\\T\\P1\\194957.ddaugher\\s\\make GAMMADIR=C:\\jprt\\T\\P1\\194957.ddaugher\\s MAKE_VERBOSE=y HOTSPOT_RELEASE_VERSION=24.0-b10 JRE_RELEASE_VERSION="1.8.0" HOTSPOT_BUILD_VERSION=internal-201205161949.ddaugher.7165060_for_hsx24 product
2012-05-16-194957.ddaugher.7165060_for_hsx24/logs/windows_i586_5.1-product.log:                ARCH=x86 BUILDARCH=i486 Platform_arch=x86 Platform_arch_model=x86_32 ARCH=x86 BUILDARCH=i486 Platform_arch=x86 Platform_arch_model=x86_32 ENABLE_FULL_DEBUG_SYMBOLS=1 ZIP_DEBUGINFO_FILES=0 RM="rm -f" ZIPEXE=zip JDK_MKTG_VERSION=8.0 JDK_MAJOR_VER=1 JDK_MINOR_VER=8 JDK_MICRO_VER=0 BUILD_WIN_SA=1 JAVA_HOME=C:\\jprt\\products\\P1\\jdk6u18-fcs\\jdk1.6.0_18 OUTPUTDIR=C:\\jprt\\T\\P1\\194957.ddaugher\\s\\build\\windows GAMMADIR=C:\\jprt\\T\\P1\\194957.ddaugher\\s MAKE_VERBOSE=y HOTSPOT_RELEASE_VERSION=24.0-b10 JRE_RELEASE_VERSION="1.8.0" HOTSPOT_BUILD_VERSION=internal-201205161949.ddaugher.7165060_for_hsx24 product
2012-05-16-194957.ddaugher.7165060_for_hsx24/logs/windows_i586_5.1-product.log:                ARCH=x86 BUILDARCH=i486 Platform_arch=x86 Platform_arch_model=x86_32 ARCH=x86 BUILDARCH=i486 Platform_arch=x86 Platform_arch_model=x86_32 ENABLE_FULL_DEBUG_SYMBOLS=1 ZIP_DEBUGINFO_FILES=0 RM="rm -f" ZIPEXE=zip JDK_MKTG_VERSION=8.0 JDK_MAJOR_VER=1 JDK_MINOR_VER=8 JDK_MICRO_VER=0 BUILD_WIN_SA=1 JAVA_HOME=C:\\jprt\\products\\P1\\jdk6u18-fcs\\jdk1.6.0_18 OUTPUTDIR=C:\\jprt\\T\\P1\\194957.ddaugher\\s\\build\\windows GAMMADIR=C:\\jprt\\T\\P1\\194957.ddaugher\\s MAKE_VERBOSE=y HOTSPOT_RELEASE_VERSION=24.0-b10 JRE_RELEASE_VERSION="1.8.0" HOTSPOT_BUILD_VERSION=internal-201205161949.ddaugher.7165060_for_hsx24 product
2012-05-16-194957.ddaugher.7165060_for_hsx24/logs/windows_x64_5.2-product.log:                 LP64=1 ARCH=x86 BUILDARCH=amd64 Platform_arch=x86 Platform_arch_model=x86_64 ENABLE_FULL_DEBUG_SYMBOLS=1 ZIP_DEBUGINFO_FILES=0 RM="rm -f" ZIPEXE=zip JDK_MKTG_VERSION=8.0 JDK_MAJOR_VER=1 JDK_MINOR_VER=8 JDK_MICRO_VER=0 BUILD_WIN_SA=1 JAVA_HOME=C:\\jprt\\products\\P1\\jdk6u18-fcs\\jdk1.6.0_18 OUTPUTDIR=C:\\jprt\\T\\P1\\194957.ddaugher\\s\\make GAMMADIR=C:\\jprt\\T\\P1\\194957.ddaugher\\s MAKE_VERBOSE=y HOTSPOT_RELEASE_VERSION=24.0-b10 JRE_RELEASE_VERSION="1.8.0"
 HOTSPOT_BUILD_VERSION=internal-201205161949.ddaugher.7165060_for_hsx24 product


The next RT_Baseline job went thru the JPRT-east queue and
has the same code:

$ grep ZIP_DEBUGINFO_FILES 2012-05-16-122934.kmcguiga.7168433/sourcetree/make/windows/makefiles/defs.make 
# The ZIP_DEBUGINFO_FILES option only has meaning when FDS is enabled.
  # Disable ZIP_DEBUGINFO_FILES by default because various tests are
  ZIP_DEBUGINFO_FILES ?= 0
  ZIP_DEBUGINFO_FILES=0
MAKE_ARGS += ZIP_DEBUGINFO_FILES=$(ZIP_DEBUGINFO_FILES)
    ifeq ($(ZIP_DEBUGINFO_FILES),1)
    ifeq ($(ZIP_DEBUGINFO_FILES),1)
    ifeq ($(ZIP_DEBUGINFO_FILES),1)
    ifeq ($(ZIP_DEBUGINFO_FILES),1)


But the build logs show that the ZIP_DEBUGINFO_FILES feature
is enabled:

grep ZIP_DEBUGINFO_FILES 2012-05-16-122934.kmcguiga.7168433/logs/windows_*_5*product.log
2012-05-16-122934.kmcguiga.7168433/logs/windows_i586_5.1-product.log:                  ARCH=x86 BUILDARCH=i486 Platform_arch=x86 Platform_arch_model=x86_32 ARCH=x86 BUILDARCH=i486 Platform_arch=x86 Platform_arch_model=x86_32 ENABLE_FULL_DEBUG_SYMBOLS=1 ZIP_DEBUGINFO_FILES=1 RM="rm -f" ZIPEXE=zip JDK_MKTG_VERSION=8.0 JDK_MAJOR_VER=1 JDK_MINOR_VER=8 JDK_MICRO_VER=0 BUILD_WIN_SA=1 JAVA_HOME=C:\\jprt\\products\\P1\\jdk6u18-fcs\\jdk1.6.0_18 OUTPUTDIR=C:\\jprt\\T\\P1\\122934.kmcguiga\\s\\make GAMMADIR=C:\\jprt\\T\\P1\\122934.kmcguiga\\s MAKE_VERBOSE=y HOTSPOT_RELEASE_VERSION=24.0-b10 JRE_RELEASE_VERSION="1.8.0" HOTSPOT_BUILD_VERSION=internal-201205161229.kmcguiga.7168433 product
2012-05-16-122934.kmcguiga.7168433/logs/windows_i586_5.1-product.log:                  ARCH=x86 BUILDARCH=i486 Platform_arch=x86 Platform_arch_model=x86_32 ARCH=x86 BUILDARCH=i486 Platform_arch=x86 Platform_arch_model=x86_32 ENABLE_FULL_DEBUG_SYMBOLS=1 ZIP_DEBUGINFO_FILES=1 RM="rm -f" ZIPEXE=zip JDK_MKTG_VERSION=8.0 JDK_MAJOR_VER=1 JDK_MINOR_VER=8 JDK_MICRO_VER=0 BUILD_WIN_SA=1 JAVA_HOME=C:\\jprt\\products\\P1\\jdk6u18-fcs\\jdk1.6.0_18 OUTPUTDIR=C:\\jprt\\T\\P1\\122934.kmcguiga\\s\\build\\windows GAMMADIR=C:\\jprt\\T\\P1\\122934.kmcguiga\\s MAKE_VERBOSE=y HOTSPOT_RELEASE_VERSION=24.0-b10 JRE_RELEASE_VERSION="1.8.0" HOTSPOT_BUILD_VERSION=internal-201205161229.kmcguiga.7168433 product
2012-05-16-122934.kmcguiga.7168433/logs/windows_i586_5.1-product.log:                  ARCH=x86 BUILDARCH=i486 Platform_arch=x86 Platform_arch_model=x86_32 ARCH=x86 BUILDARCH=i486 Platform_arch=x86 Platform_arch_model=x86_32 ENABLE_FULL_DEBUG_SYMBOLS=1 ZIP_DEBUGINFO_FILES=1 RM="rm -f" ZIPEXE=zip JDK_MKTG_VERSION=8.0 JDK_MAJOR_VER=1 JDK_MINOR_VER=8 JDK_MICRO_VER=0 BUILD_WIN_SA=1 JAVA_HOME=C:\\jprt\\products\\P1\\jdk6u18-fcs\\jdk1.6.0_18 OUTPUTDIR=C:\\jprt\\T\\P1\\122934.kmcguiga\\s\\build\\windows GAMMADIR=C:\\jprt\\T\\P1\\122934.kmcguiga\\s MAKE_VERBOSE=y HOTSPOT_RELEASE_VERSION=24.0-b10 JRE_RELEASE_VERSION="1.8.0" HOTSPOT_BUILD_VERSION=internal-201205161229.kmcguiga.7168433 product
2012-05-16-122934.kmcguiga.7168433/logs/windows_x64_5.2-product.log:                   LP64=1 ARCH=x86 BUILDARCH=amd64 Platform_arch=x86 Platform_arch_model=x86_64 ENABLE_FULL_DEBUG_SYMBOLS=1 ZIP_DEBUGINFO_FILES=1 RM="rm -f" ZIPEXE=zip JDK_MKTG_VERSION=8.0 JDK_MAJOR_VER=1 JDK_MINOR_VER=8 JDK_MICRO_VER=0 BUILD_WIN_SA=1 JAVA_HOME=C:\\jprt\\products\\P1\\jdk6u18-fcs\\jdk1.6.0_18 OUTPUTDIR=C:\\jprt\\T\\P1\\122934.kmcguiga\\s\\make GAMMADIR=C:\\jprt\\T\\P1\\122934.kmcguiga\\s MAKE_VERBOSE=y HOTSPOT_RELEASE_VERSION=24.0-b10 JRE_RELEASE_VERSION="1.8.0" HOTSPOT_BUILD_VERSION=internal-201205161229.kmcguiga.7168433 product


I have been analyzing Keith's job and I cannot find a reason
for the difference.

                                    

Comments
EVALUATION

On windows, always set ZIP_DEBUGINFO_FILES=0. This means that
the feature cannot be enabled from the command line, but that's
a necessary evil until the reason for the unexpected enabling
of the feature is understood.
                                     
2012-05-18
SUGGESTED FIX

Here is the context diff for the suggested fix:

diff -r 198dcc84088c make/windows/makefiles/defs.make
--- a/make/windows/makefiles/defs.make  Wed May 16 12:47:27 2012 -0700
+++ b/make/windows/makefiles/defs.make  Fri May 18 08:59:53 2012 -0700
@@ -145,7 +145,12 @@ ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1)
 ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1)
   # Disable ZIP_DEBUGINFO_FILES by default because various tests are
   # failing in nightly when the debug info files are ZIP'ed.
-  ZIP_DEBUGINFO_FILES ?= 0
+  #ZIP_DEBUGINFO_FILES ?= 0
+  # The above conditional setting logic is unreliable on Windows for
+  # unknown reasons. We force ZIP_DEBUGINFO_FILES to be disabled on
+  # Windows until we figure out why the various tests are failing
+  # AND why the conditional setting logic is unreliable.
+  ZIP_DEBUGINFO_FILES=0
 else
   ZIP_DEBUGINFO_FILES=0
 endif
                                     
2012-05-18
EVALUATION

http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4b37c0dafe3a
                                     
2012-05-18
EVALUATION

http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/4b37c0dafe3a
                                     
2012-05-23
EVALUATION

http://hg.openjdk.java.net/lambda/lambda/hotspot/rev/4b37c0dafe3a
                                     
2012-06-29



Hardware and Software, Engineered to Work Together