United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: JDK-7164344 enabling ZIP_DEBUGINFO_FILES causes unexpected test failures on Solaris and Windows
JDK-7164344 : enabling ZIP_DEBUGINFO_FILES causes unexpected test failures on Solaris and Windows

Details
Type:
Bug
Submit Date:
2012-04-25
Status:
Closed
Updated Date:
2013-07-18
Project Name:
JDK
Resolved Date:
2012-05-04
Component:
hotspot
OS:
solaris,windows
Sub-Component:
build
CPU:
generic
Priority:
P2
Resolution:
Fixed
Affected Versions:
hs24
Fixed Versions:
hs24 (b09)

Related Reports
Backport:
Backport:
Backport:
Backport:
Backport:
Relates:
Relates:
Relates:

Sub Tasks

Description
The push of the following two fixes to RT_Baseline caused massive
test failures on Solaris and Windows:

    7102323 4/4 RFE: enable Full Debug Symbols Phase 1 on Solaris
    7158067 4/4 FDS: ENABLE_FULL_DEBUG_SYMBOLS flag should only affect
                product builds

See the 2012-04-24 RT_Baseline nightly.

                                    

Comments
EVALUATION

For Windows, change the default ZIP_DEBUGINFO_FILES from '1' to '0'.
That disables .diz file creation by default and the tests that
were failing due to missing '.pdb' files should now pass.

For Solaris, change the default ZIP_DEBUGINFO_FILES from '1' to '0'.
Also change the default FULL_DEBUG_SYMBOLS from '1' to '0' because
unZIP'ed debug info files on Solaris have too big of an impact on
disk space footprint.

Since Linux testing didn't have any FDS failures, it looks like
Linux is OK with the new defaults.
                                     
2012-04-25
SUGGESTED FIX

Context diff for the proposed fix:

diff -r 74c359c4a9e5 make/solaris/makefiles/defs.make
--- a/make/solaris/makefiles/defs.make  Tue Apr 24 15:20:40 2012 -0700
+++ b/make/solaris/makefiles/defs.make  Wed Apr 25 13:05:24 2012 -0700
@@ -109,12 +109,18 @@ ifeq ($(JDK6_OR_EARLIER),0)
   # overridden in some situations, e.g., a BUILD_FLAVOR != product
   # build.
 
+  # Disable FULL_DEBUG_SYMBOLS by default because dtrace tests are
+  # failing in nightly when the debug info files are ZIP'ed. On
+  # Solaris debug info files need to be ZIP'ed to reduce the impact
+  # on disk space footprint.
+  FULL_DEBUG_SYMBOLS ?= 0
   ifeq ($(BUILD_FLAVOR), product)
-    FULL_DEBUG_SYMBOLS ?= 1
+    # FULL_DEBUG_SYMBOLS ?= 1
     ENABLE_FULL_DEBUG_SYMBOLS = $(FULL_DEBUG_SYMBOLS)
   else
     # debug variants always get Full Debug Symbols (if available)
-    ENABLE_FULL_DEBUG_SYMBOLS = 1
+    # ENABLE_FULL_DEBUG_SYMBOLS = 1
+    ENABLE_FULL_DEBUG_SYMBOLS = $(FULL_DEBUG_SYMBOLS)
   endif
   _JUNK_ := $(shell \
     echo >&2 "INFO: ENABLE_FULL_DEBUG_SYMBOLS=$(ENABLE_FULL_DEBUG_SYMBOLS)")
@@ -172,7 +178,9 @@ ifeq ($(JDK6_OR_EARLIER),0)
     _JUNK_ := $(shell \
       echo >&2 "INFO: STRIP_POLICY=$(STRIP_POLICY)")
 
-    ZIP_DEBUGINFO_FILES ?= 1
+    # Disable ZIP_DEBUGINFO_FILES by default because dtrace tests are
+    # failing in nightly when the debug info files are ZIP'ed.
+    ZIP_DEBUGINFO_FILES ?= 0
 
     _JUNK_ := $(shell \
       echo >&2 "INFO: ZIP_DEBUGINFO_FILES=$(ZIP_DEBUGINFO_FILES)")
diff -r 74c359c4a9e5 make/windows/makefiles/defs.make
--- a/make/windows/makefiles/defs.make  Tue Apr 24 15:20:40 2012 -0700
+++ b/make/windows/makefiles/defs.make  Wed Apr 25 13:05:24 2012 -0700
@@ -143,7 +143,9 @@ MAKE_ARGS += ENABLE_FULL_DEBUG_SYMBOLS=$
 MAKE_ARGS += ENABLE_FULL_DEBUG_SYMBOLS=$(ENABLE_FULL_DEBUG_SYMBOLS)
 
 ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1)
-  ZIP_DEBUGINFO_FILES ?= 1
+  # Disable ZIP_DEBUGINFO_FILES by default because various tests are
+  # failing in nightly when the debug info files are ZIP'ed.
+  ZIP_DEBUGINFO_FILES ?= 0
 else
   ZIP_DEBUGINFO_FILES=0
 endif
                                     
2012-04-25
EVALUATION

http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d6c393b0164b
                                     
2012-04-25
EVALUATION

http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/d6c393b0164b
                                     
2012-05-02
EVALUATION

http://hg.openjdk.java.net/hsx/hsx23.2/hotspot/rev/690f89a699b1
                                     
2012-05-08
EVALUATION

http://hg.openjdk.java.net/lambda/lambda/hotspot/rev/d6c393b0164b
                                     
2012-06-29
image was reduced after zipping
                                     
2013-05-17



Hardware and Software, Engineered to Work Together