United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: JDK-7159320 change default ZIP_DEBUGINFO_FILES back to '1' after fix for 7133529 is available
JDK-7159320 : change default ZIP_DEBUGINFO_FILES back to '1' after fix for 7133529 is available

Details
Type:
Bug
Submit Date:
2012-04-05
Status:
Resolved
Updated Date:
2012-04-27
Project Name:
JDK
Resolved Date:
2012-04-24
Component:
infrastructure
OS:
generic
Sub-Component:
build
CPU:
generic
Priority:
P3
Resolution:
Fixed
Affected Versions:
8
Fixed Versions:

Related Reports
Backport:
Relates:
Relates:
Relates:

Sub Tasks

Description
The fix for the following bug:

7133529 2/2 Debuginfo files are missing in binaries starting 7u4 b08

was originally supposed to be promoted in JDK8-B33 and JDK7u6-B04.
However, there were issues during PIT (unrelated to 7133529) so
the next integration window for 7133529 is JDK8-B35. I don't know
the next JDK7u6 integration window; perhaps JDK7u6-B06?

The fix for 7133529 includes code to properly handle the new ZIP'ed
debug info files, i.e., .diz files. Since the code for 7133529 is
not yet available, the default for the ZIP_DEBUGINFO_FILES build
flag has to change from '1' to '0'. I made that change as part of a
last minute addition to the fix for the following:

7157296 3/4 FDS: ENABLE_FULL_DEBUG_SYMBOLS flag should only affect
            OPT builds

Here are the context diffs for that change:

< diff -r e7f813f2ea86 make/common/Defs-linux.gmk
< --- a/make/common/Defs-linux.gmk      Fri Mar 23 09:27:44 2012 -0700
< +++ b/make/common/Defs-linux.gmk      Thu Mar 29 10:36:16 2012 -0700
---
> > diff -r d0e8c9361bc0 make/common/Defs-linux.gmk
> > --- a/make/common/Defs-linux.gmk      Tue Apr 03 11:52:06 2012 +0900
> > +++ b/make/common/Defs-linux.gmk      Tue Apr 03 12:00:06 2012 -0700
42,44c42,55
< diff -r e7f813f2ea86 make/common/Defs-solaris.gmk
< --- a/make/common/Defs-solaris.gmk    Fri Mar 23 09:27:44 2012 -0700
< +++ b/make/common/Defs-solaris.gmk    Thu Mar 29 10:36:16 2012 -0700
---
> > @@ -122,7 +151,9 @@ ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1)
> >      _JUNK_ := $(shell \
> >        echo >&2 "INFO: STRIP_POLICY=$(STRIP_POLICY)")
> >  
> > -    ZIP_DEBUGINFO_FILES ?= 1
> > +    # HACK: disable ZIP_DEBUGINFO_FILES by default until install repo
> > +    # changes are promoted
> > +    ZIP_DEBUGINFO_FILES ?= 0
> >  
> >      _JUNK_ := $(shell \
> >        echo >&2 "INFO: ZIP_DEBUGINFO_FILES=$(ZIP_DEBUGINFO_FILES)")
> > diff -r d0e8c9361bc0 make/common/Defs-solaris.gmk
> > --- a/make/common/Defs-solaris.gmk    Tue Apr 03 11:52:06 2012 +0900
> > +++ b/make/common/Defs-solaris.gmk    Tue Apr 03 12:00:06 2012 -0700
83,86c94,108
< diff -r e7f813f2ea86 make/common/Defs-windows.gmk
< --- a/make/common/Defs-windows.gmk    Fri Mar 23 09:27:44 2012 -0700
< +++ b/make/common/Defs-windows.gmk    Thu Mar 29 10:36:16 2012 -0700
< @@ -76,15 +76,43 @@ EXTRA_LFLAGS += /LIBPATH:$(DXSDK_LIB_PAT
---
> > @@ -130,7 +159,9 @@ ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1)
> >      _JUNK_ := $(shell \
> >        echo >&2 "INFO: STRIP_POLICY=$(STRIP_POLICY)")
> >  
> > -    ZIP_DEBUGINFO_FILES ?= 1
> > +    # HACK: disable ZIP_DEBUGINFO_FILES by default until install repo
> > +    # changes are promoted
> > +    ZIP_DEBUGINFO_FILES ?= 0
> >  
> >      _JUNK_ := $(shell \
> >        echo >&2 "INFO: ZIP_DEBUGINFO_FILES=$(ZIP_DEBUGINFO_FILES)")
> > diff -r d0e8c9361bc0 make/common/Defs-windows.gmk
> > --- a/make/common/Defs-windows.gmk    Tue Apr 03 11:52:06 2012 +0900
> > +++ b/make/common/Defs-windows.gmk    Tue Apr 03 12:00:06 2012 -0700
> > @@ -76,15 +76,45 @@ EXTRA_LFLAGS += /LIBPATH:$(DXSDK_LIB_PAT
124c146,149
<    ZIP_DEBUGINFO_FILES ?= 1
---
> > -  ZIP_DEBUGINFO_FILES ?= 1
> > +  # HACK: disable ZIP_DEBUGINFO_FILES by default until install repo
> > +  # changes are promoted
> > +  ZIP_DEBUGINFO_FILES ?= 0

                                    

Comments
EVALUATION

Revert the last minute changes added by 7157296 when the fix
for 7133529 is available.
                                     
2012-04-05
EVALUATION

The install repo for JDK8-B35 has passed PIT so the fix for 7133529
will be included with those changes. The fix for this bug is clear
to go into the T&L snapshot for JDK8-B36.
                                     
2012-04-17
EVALUATION

Changeset: cce6147632cf
Author:    dcubed
Date:      2012-04-17 09:02 -0700
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cce6147632cf

7159320: change default ZIP_DEBUGINFO_FILES back to '1' after fix for 7133529 is available
Reviewed-by: ohair, jmelvin, sspitsyn

! make/common/Defs-linux.gmk
! make/common/Defs-solaris.gmk
! make/common/Defs-windows.gmk
                                     
2012-04-17



Hardware and Software, Engineered to Work Together