United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: JDK-7152961 InlineTree::should_not_inline may exit prematurely
JDK-7152961 : InlineTree::should_not_inline may exit prematurely

Details
Type:
Bug
Submit Date:
2012-03-12
Status:
Resolved
Updated Date:
2013-04-30
Project Name:
JDK
Resolved Date:
2012-03-24
Component:
hotspot
OS:
generic
Sub-Component:
compiler
CPU:
generic
Priority:
P5
Resolution:
Fixed
Affected Versions:
hs24
Fixed Versions:
hs24 (b05)

Related Reports
Backport:
Backport:

Sub Tasks

Description
InlineTree::should_not_inline may exit prematurely.

In the middle of InlineTree::should_not_inline there is a check that makes trivial sized method return NULL/false early. 

"// use frequency-based objections only for non-trivial methods"

So any relevant clause after will never be run for many very small methods. One effect is that compilerOracle dont-inline commands are not always respected. This does not seem to be the intention.

Moving compilerOracle and string cache heuristics above that check, leaving the clauses that actually depend on frequency/profiling in place.

                                    

Comments
EVALUATION

See description
                                     
2012-03-12
EVALUATION

http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/0f4014d7731b
                                     
2012-03-13
EVALUATION

http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0f4014d7731b
                                     
2012-03-28



Hardware and Software, Engineered to Work Together