United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: JDK-7146354 Re-enable Compressed OOPs after 7118647 is resolved
JDK-7146354 : Re-enable Compressed OOPs after 7118647 is resolved

Details
Type:
Bug
Submit Date:
2012-02-16
Status:
Closed
Updated Date:
2012-10-01
Project Name:
JDK
Resolved Date:
2012-03-24
Component:
hotspot
OS:
os_x,generic
Sub-Component:
runtime
CPU:
x86,generic
Priority:
P3
Resolution:
Fixed
Affected Versions:
hs23
Fixed Versions:
hs23 (b16)

Related Reports
Backport:
Backport:
Duplicate:
Duplicate:

Sub Tasks

Description
After 7118647 is resolved, apply the fix and re-enable Compressed OOPs.

                                    

Comments
SUGGESTED FIX

diff --git a/src/share/vm/runtime/virtualspace.cpp b/src/share/vm/runtime/virtualspace.cpp
--- a/src/share/vm/runtime/virtualspace.cpp
+++ b/src/share/vm/runtime/virtualspace.cpp
@@ -455,7 +455,7 @@
 
 void ReservedSpace::protect_noaccess_prefix(const size_t size) {
   assert( (_noaccess_prefix != 0) == (UseCompressedOops && _base != NULL &&
-                                      (size_t(_base + _size) > OopEncodingHeapMax) &&
+                                      (Universe::narrow_oop_base() != NULL) &&
                                       Universe::narrow_oop_use_implicit_null_checks()),
          "noaccess_prefix should be used only with non zero based compressed oops");
 
diff --git a/src/share/vm/runtime/arguments.cpp b/src/share/vm/runtime/arguments.cpp
--- a/src/share/vm/runtime/arguments.cpp
+++ b/src/share/vm/runtime/arguments.cpp
@@ -1370,12 +1370,9 @@
   // by ergonomics.
   if (MaxHeapSize <= max_heap_for_compressed_oops()) {
 #if !defined(COMPILER1) || defined(TIERED)
-// disable UseCompressedOops by default on MacOS X until 7118647 is fixed
-#ifndef __APPLE__
     if (FLAG_IS_DEFAULT(UseCompressedOops)) {
       FLAG_SET_ERGO(bool, UseCompressedOops, true);
     }
-#endif // !__APPLE__
 #endif
 #ifdef _WIN64
     if (UseLargePages && UseCompressedOops) {
                                     
2012-02-17
EVALUATION

http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/7df3125953cb
                                     
2012-02-17
EVALUATION

http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/7df3125953cb
                                     
2012-02-18
EVALUATION

http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/7df3125953cb
                                     
2012-02-18
EVALUATION

http://hg.openjdk.java.net/lambda/lambda/hotspot/rev/7df3125953cb
                                     
2012-03-22
EVALUATION

Relax the assertion to simply check for COOP mode rather than an exact address.
                                     
2012-02-16
EVALUATION

http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7df3125953cb
                                     
2012-02-17



Hardware and Software, Engineered to Work Together