JDK-7061101 : adlc should complain about mixing block and expression forms of ins_encode
  • Type: Bug
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: hs22
  • Priority: P4
  • Status: Closed
  • Resolution: Fixed
  • OS: solaris_10
  • CPU: x86
  • Submitted: 2011-06-30
  • Updated: 2011-11-25
  • Resolved: 2011-09-30
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 7 JDK 8 Other
7u2Fixed 8Fixed hs22Fixed
Description
> That looks good.  I was a little surprised when I realized that the old code looked like this:
> 
>   ins_encode %{
>     __ fcmps($src1$$FloatRegister, $src2$$FloatRegister);
> 
>   %}
>   ins_encode( floating_cmp( dst ) );
> 
> It hadn't occurred to me that that would work but apparently it does since the underlying machinery is the same.

It doesn't work. The fcmps doesn't get emitted.

Roland.

Comments
EVALUATION http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/fe240d87c6ec
08-07-2011

EVALUATION http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/fe240d87c6ec
07-07-2011

EVALUATION 7061101: adlc should complain about mixing block and expression forms of ins_encode Reviewed-by: kvn Only one ins_encode should be specified. Tested with bad ad file.
07-07-2011

EVALUATION http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/fe240d87c6ec
06-07-2011

EVALUATION we should complain if we see both forms.
30-06-2011