United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: JDK-7061101 adlc should complain about mixing block and expression forms of ins_encode
JDK-7061101 : adlc should complain about mixing block and expression forms of ins_encode

Details
Type:
Bug
Submit Date:
2011-06-30
Status:
Closed
Updated Date:
2011-11-25
Project Name:
JDK
Resolved Date:
2011-09-30
Component:
hotspot
OS:
solaris_10
Sub-Component:
compiler
CPU:
x86
Priority:
P4
Resolution:
Fixed
Affected Versions:
hs22
Fixed Versions:
hs22 (b01)

Related Reports
Backport:
Backport:

Sub Tasks

Description
> That looks good.  I was a little surprised when I realized that the old code looked like this:
> 
>   ins_encode %{
>     __ fcmps($src1$$FloatRegister, $src2$$FloatRegister);
> 
>   %}
>   ins_encode( floating_cmp( dst ) );
> 
> It hadn't occurred to me that that would work but apparently it does since the underlying machinery is the same.

It doesn't work. The fcmps doesn't get emitted.

Roland.

                                    

Comments
EVALUATION

we should complain if we see both forms.
                                     
2011-06-30
EVALUATION

http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/fe240d87c6ec
                                     
2011-07-06
EVALUATION

7061101: adlc should complain about mixing block and expression forms of ins_encode
Reviewed-by: kvn

Only one ins_encode should be specified.  Tested with bad ad file.
                                     
2011-07-07
EVALUATION

http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/fe240d87c6ec
                                     
2011-07-07
EVALUATION

http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/fe240d87c6ec
                                     
2011-07-08



Hardware and Software, Engineered to Work Together