JDK-7060619 : C1 should respect inline and dontinline directives from CompilerOracle
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: hs22
  • Priority: P4
  • Status: Closed
  • Resolution: Fixed
  • OS: solaris_10
  • CPU: x86
  • Submitted: 2011-06-28
  • Updated: 2012-01-10
  • Resolved: 2011-09-30
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 7 JDK 8 Other
7u2Fixed 8Fixed hs22Fixed
Description
On Jun 15, 2011, at 8:31 PM, Krystal Mok wrote:

> Hi all,
> 
> Someone asked why he ran tests and found that the compiler command "dontinline" doesn't work, here:
> http://hllvm.group.iteye.com/group/topic/26381
> 
> It's clear that he's using HotSpot Client VM, so it's C1 in action. I found that C1's graph builder doesn't check
> whether a method has been tagged as "dontinline" by the CompilerOracle,

Yes it was never updated to support this.  If you want to provide a patch I can push it though I don't see you on the signatories list.

tom
Comments
EVALUATION See main CR
12-09-2011
EVALUATION http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ce3e1d4dc416
23-08-2011
EVALUATION 7060619: C1 should respect inline and dontinline directives from CompilerOracle Reviewed-by: kvn, iveresov This adds support for the inline and dontinline directives to C1. I moved several correctness guards further up so that only purely heuristic guards were at the end. Tested with various commands and PrintCompilation PrintInlining.
29-07-2011
EVALUATION http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/ce3e1d4dc416
29-07-2011