United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: JDK-7060619 C1 should respect inline and dontinline directives from CompilerOracle
JDK-7060619 : C1 should respect inline and dontinline directives from CompilerOracle

Details
Type:
Enhancement
Submit Date:
2011-06-28
Status:
Closed
Updated Date:
2012-01-10
Project Name:
JDK
Resolved Date:
2011-09-30
Component:
hotspot
OS:
solaris_10
Sub-Component:
compiler
CPU:
x86
Priority:
P4
Resolution:
Fixed
Affected Versions:
hs22
Fixed Versions:
hs22 (b02)

Related Reports
Backport:
Backport:

Sub Tasks

Description
On Jun 15, 2011, at 8:31 PM, Krystal Mok wrote:

> Hi all,
> 
> Someone asked why he ran tests and found that the compiler command "dontinline" doesn't work, here:
> http://hllvm.group.iteye.com/group/topic/26381
> 
> It's clear that he's using HotSpot Client VM, so it's C1 in action. I found that C1's graph builder doesn't check
> whether a method has been tagged as "dontinline" by the CompilerOracle,

Yes it was never updated to support this.  If you want to provide a patch I can push it though I don't see you on the signatories list.

tom

                                    

Comments
EVALUATION

http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/ce3e1d4dc416
                                     
2011-07-29
EVALUATION

7060619: C1 should respect inline and dontinline directives from CompilerOracle
Reviewed-by: kvn, iveresov

This adds support for the inline and dontinline directives to C1.  I
moved several correctness guards further up so that only purely
heuristic guards were at the end.  Tested with various commands and
PrintCompilation PrintInlining.
                                     
2011-07-29
EVALUATION

http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ce3e1d4dc416
                                     
2011-08-23
EVALUATION

See main CR
                                     
2011-09-12



Hardware and Software, Engineered to Work Together