United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: JDK-7046448 Correct webrev.ksh to tidy up html output
JDK-7046448 : Correct webrev.ksh to tidy up html output

Details
Type:
Bug
Submit Date:
2011-05-19
Status:
Resolved
Updated Date:
2011-06-30
Project Name:
JDK
Resolved Date:
2011-06-30
Component:
infrastructure
OS:
generic
Sub-Component:
build
CPU:
generic
Priority:
P4
Resolution:
Fixed
Affected Versions:
OpenJDK6
Fixed Versions:
OpenJDK6 (b23)

Related Reports

Sub Tasks

Description
Contribution from Michael Tandy

                                    

Comments
SUGGESTED FIX

make/scripts/webrev.ksh
Print this page

@@ -87,11 +87,11 @@
     color: green;
     font-size: large;
     font-weight: bold;
 }
 span.removed {
-    color: brown;
+    color: #A52A2A; /*brown*/
 }
 span.changed {
     color: blue;
 }
 span.new {

@@ -507,11 +507,12 @@
 
         # Enable html files to access WDIR via a relative path.
         RTOP=$(relative_dir $TPATH $WDIR)
 
         # Make the rhs/lhs files and output the frameset file.
-        print "$HTML<head>$STDHEAD" > $WDIR/$DIR/$TNAME.lhs.html
+        print "$HTML<head>$STDHEAD <title>$WNAME rhs/lhs "\
+                "$TPATH/$TNAME</title>" > $WDIR/$DIR/$TNAME.lhs.html
 
         cat >> $WDIR/$DIR/$TNAME.lhs.html <<-EOF
             <script type="text/javascript" src="$RTOP/ancnav.js"></script>
             </head>
             <body id="SUNWwebrev" onkeypress="keypress(event);">

@@ -660,11 +661,11 @@
 
                 printf "<b style=\"font-size: large; color: red\">";
                 printf "--- EOF ---</b>"
                 for(i=0;i<8;i++) printf "\n\n\n\n\n\n\n\n\n\n";
                 printf "</pre>"
-                printf "<form name=\"eof\">";
+                printf "<form name=\"eof\" action=\"#\">";
                 printf "<input name=\"value\" value=\"%d\" type=\"hidden\" />",
                     anc - 1;
                 printf "</form>";
         }
         ' $1

@@ -924,48 +925,48 @@
           <td align="center" valign="top" width="50%">
             <div class="button">
               <table border="0" align="center">
                   <tr>
                     <td>
-                      <a onMouseDown="handlePress(1);return true;"
-                         onMouseUp="handleRelease(1);return true;"
-                         onMouseOut="handleRelease(1);return true;"
-                         onClick="return false;"
+                      <a onmousedown="handlePress(1);return true;"
+                         onmouseup="handleRelease(1);return true;"
+                         onmouseout="handleRelease(1);return true;"
+                         onclick="return false;"
                          title="Go to Beginning Of file">BOF</a></td>
                     <td>
-                      <a onMouseDown="handlePress(3);return true;"
-                         onMouseUp="handleRelease(3);return true;"
-                         onMouseOut="handleRelease(3);return true;"
+                      <a onmousedown="handlePress(3);return true;"
+                         onmouseup="handleRelease(3);return true;"
+                         onmouseout="handleRelease(3);return true;"
                          title="Scroll Up: Press and Hold to accelerate"
-                         onClick="return false;">Scroll Up</a></td>
+                         onclick="return false;">Scroll Up</a></td>
                     <td>
-                      <a onMouseDown="handlePress(2);return true;"
-                         onMouseUp="handleRelease(2);return true;"
-                         onMouseOut="handleRelease(2);return true;"
+                      <a onmousedown="handlePress(2);return true;"
+                         onmouseup="handleRelease(2);return true;"
+                         onmouseout="handleRelease(2);return true;"
                          title="Go to previous Diff"
-                         onClick="return false;">Prev Diff</a>
+                         onclick="return false;">Prev Diff</a>
                     </td></tr>
 
                   <tr>
                     <td>
-                      <a onMouseDown="handlePress(6);return true;"
-                         onMouseUp="handleRelease(6);return true;"
-                         onMouseOut="handleRelease(6);return true;"
-                         onClick="return false;"
+                      <a onmousedown="handlePress(6);return true;"
+                         onmouseup="handleRelease(6);return true;"
+                         onmouseout="handleRelease(6);return true;"
+                         onclick="return false;"
                          title="Go to End Of File">EOF</a></td>
                     <td>
-                      <a onMouseDown="handlePress(4);return true;"
-                         onMouseUp="handleRelease(4);return true;"
-                         onMouseOut="handleRelease(4);return true;"
+                      <a onmousedown="handlePress(4);return true;"
+                         onmouseup="handleRelease(4);return true;"
+                         onmouseout="handleRelease(4);return true;"
                          title="Scroll Down: Press and Hold to accelerate"
-                         onClick="return false;">Scroll Down</a></td>
+                         onclick="return false;">Scroll Down</a></td>
                     <td>
-                      <a onMouseDown="handlePress(5);return true;"
-                         onMouseUp="handleRelease(5);return true;"
-                         onMouseOut="handleRelease(5);return true;"
+                      <a onmousedown="handlePress(5);return true;"
+                         onmouseup="handleRelease(5);return true;"
+                         onmouseout="handleRelease(5);return true;"
                          title="Go to next Diff"
-                         onClick="return false;">Next Diff</a></td>
+                         onclick="return false;">Next Diff</a></td>
                   </tr>
               </table>
             </div>
           </td>
           <th valign="middle" width="25%">

@@ -1021,11 +1022,11 @@
         /^-------/      { printf "<center><h1>%s</h1></center>\n", $0; next }
         /^\@\@.*\@\@$/  { printf "</pre><hr /><pre>\n";
                           printf "<span class=\"newmarker\">%s</span>\n", $0;
                           next}
 
-        /^\*\*\*/       { printf "<hr /><span class=\"oldmarker\">%s</span>\n", $0;
+        /^\*\*\*/       { printf "</pre><hr /><pre><span class=\"oldmarker\">%s</span>\n", $0;
                           next}
         /^---/          { printf "<span class=\"newmarker\">%s</span>\n", $0;
                           next}
         /^\+/           {printf "<span class=\"new\">%s</span>\n", $0; next}
         /^!/            {printf "<span class=\"changed\">%s</span>\n", $0; next}

@@ -1047,11 +1048,11 @@
         WHICH=$1
         TNAME=$2
 
         print "$HTML<head>$STDHEAD"
         print "<title>$WHICH $TNAME</title>"
-        print "<body id=\"SUNWwebrev\">"
+        print "</head><body id=\"SUNWwebrev\">"
         print "<pre>"
         html_quote | $AWK '{line += 1 ; printf "%4d %s\n", line, $0 }'
         print "</pre></body></html>"
 }
 

@@ -3018,11 +3019,11 @@
         
         print "</td></tr>"
     done
 fi
 print "<tr><th>Legend:</th><td>"
-print "<b>Modified file</b><br><font color=red><b>Deleted file</b></font><br><font color=green><b>New file</b></font></td></tr>"
+print "<b>Modified file</b><br /><font color=\"red\"><b>Deleted file</b></font><br /><font color=\"green\"><b>New file</b></font></td></tr>"
 print "</table>"
 print "</div>"
 
 #
 # Second pass through the files: generate the rest of the index file

@@ -3158,11 +3159,11 @@
 print
 print
 print "<hr />"
 print "<p style=\"font-size: small\">"
 print "This code review page was prepared using <b>$0</b>"
-print "(vers $WEBREV_UPDATED)."
+print "(vers $WEBREV_UPDATED).</p>"
 print "</body>"
 print "</html>"
 
 if [[ -n $ZIP ]]; then
     # Let's generate a zip file for convenience
                                     
2011-05-19
EVALUATION

Fixes to generate more correct html.
                                     
2011-05-19
EVALUATION

http://hg.openjdk.java.net/jdk6/jdk6/rev/1512bd8466f2
                                     
2011-06-30



Hardware and Software, Engineered to Work Together