United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
JDK-7000225 : Sanity check on sane-alsa-headers is broken

Details
Type:
Bug
Submit Date:
2010-11-15
Status:
Resolved
Updated Date:
2010-12-21
Project Name:
JDK
Resolved Date:
2010-12-21
Component:
infrastructure
OS:
generic
Sub-Component:
build
CPU:
generic
Priority:
P2
Resolution:
Fixed
Affected Versions:
7
Fixed Versions:

Related Reports

Sub Tasks

Description
The sane-alsa-headers rules in the file jdk/make/common/shared/Sanity.gmk is broken.
There is a missing tab character in front of the first if test, and it contains an extra fi.

diff --git a/make/common/shared/Sanity.gmk b/make/common/shared/Sanity.gmk
--- a/make/common/shared/Sanity.gmk
+++ b/make/common/shared/Sanity.gmk
@@ -1389,14 +1389,13 @@
 endif
 sane-alsa-headers:
 ifdef REQUIRED_ALSA_VERSION
-        if [ "$(ALSA_CHECK)" != "same" -a "$(ALSA_CHECK)" != "newer"  ] ; then \
+	@if [ "$(ALSA_CHECK)" != "same" -a "$(ALSA_CHECK)" != "newer"  ] ; then \
 	    $(ECHO) "ERROR: The ALSA version must be $(REQUIRED_ALSA_VERSION) or higher. \n" \
 	      "      You have the following ALSA version installed: $${alsa_version) \n" \
 	      "      Please reinstall ALSA (drivers and lib). You can download \n" \
 	      "      the source distribution from http://www.alsa-project.org \n" \
 	      "      or go to http://www.freshrpms.net/docs/alsa/ for precompiled RPM packages. \n" \
 	      "" >> $(ERROR_FILE) ; \
-	  fi \
 	else \
 	  $(ECHO) "ERROR: You seem to not have installed ALSA $(REQUIRED_ALSA_VERSION) or higher. \n" \
 	  "      Please install ALSA (drivers and lib). You can download the \n" \

                                    

Comments
EVALUATION

http://hg.openjdk.java.net/jdk7/build/jdk/rev/beb9f3298ad3
                                     
2010-11-24
EVALUATION

See description.
                                     
2010-11-22



Hardware and Software, Engineered to Work Together