United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: JDK-6991065 missed a review comment in 6829194
JDK-6991065 : missed a review comment in 6829194

Details
Type:
Bug
Submit Date:
2010-10-11
Status:
Closed
Updated Date:
2011-04-23
Project Name:
JDK
Resolved Date:
2011-04-23
Component:
hotspot
OS:
generic
Sub-Component:
compiler
CPU:
generic
Priority:
P3
Resolution:
Fixed
Affected Versions:
hs20
Fixed Versions:
hs20 (b02)

Related Reports
Backport:
Backport:
Relates:

Sub Tasks

Description
As Vladimir pointed out, I missed to add a review comment:

!       if (UseCompressedOops)  fac_ptr->nonstatic_double_count += 1;

should be

!       if (wordSize == longSize)  fac_ptr->nonstatic_double_count += 1;

Since it is raw it should not depend on coop.

                                    

Comments
EVALUATION

Yes
                                     
2010-10-11
SUGGESTED FIX

http://cr.openjdk.java.net/~twisti/6991065/webrev.01/
                                     
2010-10-11
EVALUATION

http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/a932f331ef90
                                     
2010-10-12



Hardware and Software, Engineered to Work Together