United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: JDK-6987107 Add variable to add to but not modify non-fcs version string
JDK-6987107 : Add variable to add to but not modify non-fcs version string

Details
Type:
Enhancement
Submit Date:
2010-09-24
Status:
Closed
Updated Date:
2011-05-17
Project Name:
JDK
Resolved Date:
2011-05-17
Component:
infrastructure
OS:
generic
Sub-Component:
build
CPU:
generic
Priority:
P2
Resolution:
Fixed
Affected Versions:
7,8
Fixed Versions:

Related Reports
Backport:
Duplicate:

Sub Tasks

Description
Currently JPRT overrides MILESTONE to something that describes the build being done, with a username job id etc.

The jdk7 Hudson system needs to do the same thing.

However, MILESTONE appears to have specific values, e.g. "ea", "fcs", or "internal". And in fact some makefiles actually check for these values. Which means that the build can behave differently if MILESTONE is not one of these 3 values.
Use of RELEASE and FULL_VERSION have similar issues.

What is needed is a way to add to the version string, only for non-fcs builds, some kind of build info.

Proposal is to add a NONFCS_BUILD_INFO variable for this, whose default is empty.

Then:
ifneq ($(MILESTONE),fcs)
  Add $(NONFCS_BUILD_INFO) right after $(MILESTONE)
endif

It would need to be set to something like: NONFCS_BUILD_INFO=-nightly-re  or NONFCS_BUILD_INFO=-jprt-JOBID or whatever.

The jdk and hotspot makefiles would need to change to adopt.

The current JPRT_BUILD_VERSION could be retired.

Adding some checks to make sure MILESTONE is one of a set of fixed patterns might be a good sanity check.

                                    

Comments
EVALUATION

See description.
                                     
2010-09-24
EVALUATION

http://cr.openjdk.java.net/~ohair/openjdk7/nonfcs-version/webrev/
                                     
2010-11-24
EVALUATION

http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/c7db7adb83b4
                                     
2010-12-01
EVALUATION

http://hg.openjdk.java.net/jdk7/build/jdk/rev/fd6873594ae2
                                     
2010-12-01
EVALUATION

FYI...  The name is USER_RELEASE_SUFFIX
                                     
2010-12-01
EVALUATION

http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/c7db7adb83b4
                                     
2010-12-09
EVALUATION

http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/c7db7adb83b4
                                     
2010-12-10
EVALUATION

http://hg.openjdk.java.net/jdk7/build/hotspot/rev/c7db7adb83b4
                                     
2010-12-25



Hardware and Software, Engineered to Work Together