United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: JDK-6961536 Nimbus code using @Override break OpenJDK/IcedBuild on ecj
JDK-6961536 : Nimbus code using @Override break OpenJDK/IcedBuild on ecj

Details
Type:
Enhancement
Submit Date:
2010-06-16
Status:
Resolved
Updated Date:
2010-06-16
Project Name:
JDK
Resolved Date:
2010-06-16
Component:
infrastructure
OS:
generic
Sub-Component:
build
CPU:
generic
Priority:
P4
Resolution:
Fixed
Affected Versions:
OpenJDK6
Fixed Versions:
OpenJDK6 (b20)

Related Reports
Relates:

Sub Tasks

Description
The latest round of porting Nimbus fixes from JDK 7 to OpenJDK 6 introduced some uses of @Override that are not accepted by JDK 5-era compilers, such as ecj used in some OpenJDK/IcedTea build scenarios.

                                    

Comments
EVALUATION

Yes.
                                     
2010-06-16
SUGGESTED FIX

# HG changeset patch
# User andrew
# Date 1276694000 -3600
# Node ID 6ef1ef04bf30fd4c771be6b416905397ae0468ef
# Parent 38d41e1f149338e3ecd009e95f8f6dc30196bc6a
6961536: Nimbus code using @Override breaks build with source/target 1.5
Summary: @Override on annotations is only allowed with source 1.6
Reviewed-by: darcy

--- a/make/javax/swing/Makefile	Tue Jun 15 16:42:54 2010 +0800
+++ b/make/javax/swing/Makefile	Wed Jun 16 14:13:20 2010 +0100
@@ -35,6 +35,8 @@ NIMBUS_GENERATOR_JAR = $(BUILDTOOLJARDIR
 NIMBUS_GENERATOR_JAR = $(BUILDTOOLJARDIR)/generatenimbus.jar
 
 include $(BUILDDIR)/common/Defs.gmk
+LANGUAGE_VERSION = -source 6
+CLASS_VERSION = -target 6
 
 #
 # Files
--- a/make/javax/swing/plaf/Makefile	Tue Jun 15 16:42:54 2010 +0800
+++ b/make/javax/swing/plaf/Makefile	Wed Jun 16 14:13:20 2010 +0100
@@ -29,6 +29,8 @@ SWING_SRC = $(SHARE_SRC)/classes/javax/s
 SWING_SRC = $(SHARE_SRC)/classes/javax/swing
 
 include $(BUILDDIR)/common/Defs.gmk
+LANGUAGE_VERSION = -source 6
+CLASS_VERSION = -target 6
 
 #
 # Files
                                     
2010-06-16
PUBLIC COMMENTS

See
http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/6ef1ef04bf30
                                     
2010-06-16



Hardware and Software, Engineered to Work Together