United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: JDK-6941224 Improved stack overflow handling for Zero
JDK-6941224 : Improved stack overflow handling for Zero

Details
Type:
Enhancement
Submit Date:
2010-04-06
Status:
Closed
Updated Date:
2012-10-13
Project Name:
JDK
Resolved Date:
2010-05-05
Component:
hotspot
OS:
generic
Sub-Component:
runtime
CPU:
generic
Priority:
P4
Resolution:
Fixed
Affected Versions:
hs18
Fixed Versions:
hs18 (b04)

Related Reports
Backport:
Backport:
Backport:
Backport:
Relates:
Relates:

Sub Tasks

Description
Gary Benson wrote:

Hi all,

I recently started adding stack overflow checking to Shark,
which brought to light a bunch of deficiencies in Zero's
stack overflow code.  Zero had this really odd, look-ahead
overflow handling which was pretty strange, easily fooled,
and in retrospect totally unnecessary.  I'm pretty sure
whoever wrote it was an idiot.

This webrev removes the old overflow detection and replaces
it with something more straightforward and complete:

  http://cr.openjdk.java.net/~gbenson/zero-stack-overflow-checks/

Note that a number of calls to Unimplemented have been removed.
It shouldn't be possible to have an unhandled stack overflow
error with the new code.

As a bonus, the new code is mildly faster (about 2%) due to
the checks being inlined.

I don't have a bug id for this.

Cheers,
Gary

                                    

Comments
EVALUATION

http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/f9271ff9d324
                                     
2010-04-16



Hardware and Software, Engineered to Work Together