United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: JDK-6921922 fix for 6911204 breaks tagged stack interpreter
JDK-6921922 : fix for 6911204 breaks tagged stack interpreter

Details
Type:
Bug
Submit Date:
2010-02-01
Status:
Closed
Updated Date:
2012-10-08
Project Name:
JDK
Resolved Date:
2010-02-09
Component:
hotspot
OS:
solaris_9,generic
Sub-Component:
runtime
CPU:
sparc,generic
Priority:
P3
Resolution:
Fixed
Affected Versions:
hs17
Fixed Versions:
hs17 (b09)

Related Reports
Backport:
Backport:
Duplicate:
Relates:

Sub Tasks

Description
The new logic for sharing adapters will smear together arguments of the same size without regard to whether they are oops or not.  This is incorrect with the tagged stack interpreter since it must also set the tag bigs for them.  We need a more flexible strategy.
This bug affects the following VM/NSK test:

    nsk/jvmti/AddCapabilities/addcaps003
Could you please add the complete list of vm options too next time to make the bug easier to verify?
It looks like the test takes care of the options, but I'm not able to reproduce the failure on /net/sqenfs-1.sfbay/export1/comp/vm/jdk/hsx/17/pit/b09/jdk7b83/product or on b08/jdk782. Tried to look in nightlies for it's failure, but no luck, only one strange linux failure which doesn't reproduce. I'm trying to verify it during b09 pit which is strange, since it's said to be committed in b10.
I tried to reporoduce it via
/net/sqenfs-1.sfbay/export1/tools/gtee/harness/ute/ute -tlists empty -jdk /net/sqenfs-1.sfbay/export1/comp/vm/jdk/hsx/17/pit/b09/jdk7b83/product/solaris-sparcv9  -test nsk/jvmti/AddCapabilities/addcaps003  -vmopts "-Xmixed -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
and also on solaris-amd64 and on linux-amd64

                                    

Comments
EVALUATION

The new logic for sharing adapters will smear together arguments of
the same size without regard to whether they are oops or not. This is
incorrect with the tagged stack interpreter since it must also set the
tag bigs for them. I've changed the fingerprinter to relying purely
on the BasicType signature with a little explicit signature smearing.
This should might it run slightly faster since we don't have to go
through the calling convention for a successful lookup. There's also
a new flag VerifyAdapterSharing that checks that the code generated
for shared adapters is the same. Tested with failing test.
                                     
2010-02-04
EVALUATION

smearing of objects with other types breaks the tagging.
                                     
2010-02-01
EVALUATION

ChangeSet=http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/74c848d437ab,ChangeRequest=6921922
                                     
2010-02-03



Hardware and Software, Engineered to Work Together