United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: JDK-6813212 factor duplicated assembly code for general subclass check (for 6655638)
JDK-6813212 : factor duplicated assembly code for general subclass check (for 6655638)

Details
Type:
Enhancement
Submit Date:
2009-03-04
Status:
Resolved
Updated Date:
2010-04-02
Project Name:
JDK
Resolved Date:
2009-04-02
Component:
hotspot
OS:
generic
Sub-Component:
compiler
CPU:
generic
Priority:
P3
Resolution:
Fixed
Affected Versions:
7
Fixed Versions:
hs15 (b04)

Related Reports
Backport:
Backport:
Relates:

Sub Tasks

Description
The assembly code for the general subclass check is duplicated (with minor variations) in interp_masm, stubGenerator, and c1_LIRAssembler.  In order to control the code shape more directly, we will factor it into a new subroutine MacroAssembler::check_klass_subtype.

This will let us use the subroutine in a new places, such as code for a direct method handle which adapts to a wider incoming argument type.

It will also reduce the number of modifications required to add enhancements to subtype checking, such as for the interface injection project.

                                    

Comments
SUGGESTED FIX

http://cr.openjdk.java.net/~jrose/6813212/
                                     
2009-03-08
EVALUATION

http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/c517646eef23
                                     
2009-03-14



Hardware and Software, Engineered to Work Together