United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: JDK-6734007 sponsor transforms break non-Patch in Place upgrade functionality
JDK-6734007 : sponsor transforms break non-Patch in Place upgrade functionality

Details
Type:
Bug
Submit Date:
2008-08-05
Status:
Resolved
Updated Date:
2010-09-17
Project Name:
JDK
Resolved Date:
2008-09-04
Component:
install
OS:
windows_xp
Sub-Component:
install
CPU:
x86
Priority:
P1
Resolution:
Fixed
Affected Versions:
6u10
Fixed Versions:
6u10 (b31)

Related Reports
Backport:
Relates:
Relates:

Sub Tasks

Description
sponsor transforms remove FindRelatedProducts from the InstallUISequence

It was not meant to be that way for patch-in-place.

Need to investigate the impact.

                                    

Comments
EVALUATION

We need to first evaluate if this has any impact.  I believe the only way it could cause issues is with the offline installer, because it may (check with Chris G) use FindRelatedProducts to do the uninstall of the old release.  The Upgrade table may have something to do with this.  Also, it would only affect the -s offline, because that's the only one that has sponsor transforms.  The test we need to run is:

1. Install 6u10 
2. Install 6u11 offline -s, it should uninstall 6u10 and then start the 6u11 installation.  The behavior should be the same as if the non -s 6u11 offline installer is run.  

We should also make sure that there aren't any other actions that are getting removed by the sponsor transforms.  

The fix itself is easy.  Add one line to the fulltables/InstallUISequence.idt table in the sponsors ws.
                                     
2008-08-22
EVALUATION

This has serious impact.
Sponsor transforms break non-Patch in Place upgrade functionality.
When the installer (.exe) cannot upgrade using patch in place (offline or 6u10 non-fcs to 6u11 because CkSums do not match), 
and decides to upgrade by silently uninstalling 6u10 first, it passes REMOVEEXISTING=1 to the MSI.

When I run:
msiexec /i jre1.6.0_11-c.msi TRANSFORMS="C:\Documents and Settings\Chris\Application Data\Sun\Java\jre1.6.0_11\sp1033.MST" ED=0 SP5OFF=1 SP2OFF=1 SPWEB=http://j2se.east.sun.com/arc/1.6.0_11/nightly/2008-08-19/windows-i586/iftw/sp METHOD=jother COUNTRY=US PREFERENCEORDER=SP1;SP4;SP3 REMOVEEXISTING=1 

I get:
Error 25099. Unzipping core files failed.
because 6u10 has not been uninstalled and is still running.

If I call the MSI without the sponsor transform, it silently uninstalls 6u10 and installs 6u11:
msiexec /i jre1.6.0_11-c.msi ED=0 SP5OFF=1 SP2OFF=1 SPWEB=http://j2se.east.sun.com/arc/1.6.0_11/nightly/2008-08-19/windows-i586/iftw/sp METHOD=jother COUNTRY=US PREFERENCEORDER=SP1;SP4;SP3 REMOVEEXISTING=1
                                     
2008-08-22
EVALUATION

changed in InstallUISequence.idt revision 1.26:
D 1.26  08/05/15 17:11:16 billyh        54 53   00083/00015/00019
Merged changes between child workspace "/java/deployment/ws/1.6.0_10-ooyahoo/nightly/sponsors" and
parent workspace "/java/deployment/ws/1.6.0_10/integration/sponsors".

sccs sccsdiff -r 1.25 -r 1.26  InstallUISequence.idt | grep FindR
< FindRelatedProducts           150     FindRelatedProducts
                                     
2008-08-22
EVALUATION

Not an issue for 6u10beta->fcs.  I was confusing REMOVEEXISTING=1 and REINSTALL_NO_PROMPT=1

I installed 6u10 beta b23 and upgraded to the staged 6u10fcs w/ sponsor transform successfully.
> jre-6u10-windows-i586-p-iftw.exe REINSTALL_NO_PROMPT=1
                                     
2008-08-23
EVALUATION

in InstallUISequence.idt from revision 1.25 to 1.26:

<FindRelatedProducts		150	FindRelatedProducts	
was removed and should be re-added.

<SETMODIFYREMOVE	(VersionNT=400) OR (Version9X=490) OR (Version9X=410)	32
was changed to 
>SETMODIFYREMOVE	(VersionNT=400) OR (Version9X=490) OR (Version9X=410)	1
I don't know if this is correct.		

<needrebootIEVM	Not Installed	780	do we need a reboot for IE	
<needrebootFirefox	Not Installed	781		
was changed to 
>needrebootIEVM	Not Installed	31	do we need a reboot for IE	
>needrebootFirefox	Not Installed	32		
and then fixed.
	
The following were moved out of numerical order.
>NewerConsumerVersionInstalled	(Not REMOVE) And (MODE<>"S") And (PREV_CONSUMER_VERSION>JDK_VERSION)	151	Error if installing Consumer and newer consumer version is already installed.	
>SameVersionAlreadyInstalledAsStatic	(Not REMOVE) And (MODE<>"S") And SAMEVERSTATICPRODUCTFOUND	152	Error if installing Consumer and the same version of Static is already installed.
                                     
2008-08-23
SUGGESTED FIX

webrev: http://j2se.east/deployment/www/webrevs/qz198522/6ux/6734007/install/
testcase:
http://j2se.east/deployment/www/tests/1.6.0_11/6734007
                                     
2008-08-27



Hardware and Software, Engineered to Work Together