JDK-6724327 : eliminate use of shell tests for simple golden file tests
  • Type: Bug
  • Component: tools
  • Sub-Component: javac
  • Affected Version: 7
  • Priority: P4
  • Status: Closed
  • Resolution: Fixed
  • OS: generic
  • CPU: generic
  • Submitted: 2008-07-09
  • Updated: 2011-05-18
  • Resolved: 2011-05-18
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 7 Other
7 b32Fixed OpenJDK6Fixed
Description
The following 18 shell tests appear to be golden file tests, and could be simplified to use jtreg built-in golden file facilities:

tl/langtools/test/tools/javac/InnerNamedConstant_2.sh
tl/langtools/test/tools/javac/NonStaticFieldExpr3.sh
tl/langtools/test/tools/javac/CyclicInheritance.sh
tl/langtools/test/tools/javac/fatalErrors/NoJavaLang.sh
tl/langtools/test/tools/javac/SynchronizedClass.sh
tl/langtools/test/tools/javac/depDocComment/DeprecatedDocComment.sh
tl/langtools/test/tools/javac/NonStaticFieldExpr2.sh
tl/langtools/test/tools/javac/4846262/Test.sh
tl/langtools/test/tools/javac/QualifiedAccess/QualifiedAccess_3.sh
tl/langtools/test/tools/javac/QualifiedAccess/QualifiedAccess_2.sh
tl/langtools/test/tools/javac/QualifiedAccess/QualifiedAccess_1.sh
tl/langtools/test/tools/javac/FloatingPointChanges/BadConstructorModifiers.sh
tl/langtools/test/tools/javac/6302184/T6302184.sh
tl/langtools/test/tools/javac/ExtendsAccess/ExtendsAccess.sh
tl/langtools/test/tools/javac/NestedInnerClassNames.sh
tl/langtools/test/tools/javac/LocalClasses_2.sh
tl/langtools/test/tools/javac/NonStaticFieldExpr1.sh
tl/langtools/test/tools/javac/NameCollision.sh

Comments
EVALUATION The following tests were fixed: tl/langtools/test/tools/javac/InnerNamedConstant_2.sh DONE tl/langtools/test/tools/javac/NonStaticFieldExpr3.sh DONE tl/langtools/test/tools/javac/CyclicInheritance.sh DONE tl/langtools/test/tools/javac/SynchronizedClass.sh DONE tl/langtools/test/tools/javac/depDocComment/DeprecatedDocComment.sh DONE tl/langtools/test/tools/javac/NonStaticFieldExpr2.sh DONE tl/langtools/test/tools/javac/QualifiedAccess/QualifiedAccess_3.sh DONE tl/langtools/test/tools/javac/QualifiedAccess/QualifiedAccess_2.sh DONE tl/langtools/test/tools/javac/QualifiedAccess/QualifiedAccess_1.sh DONE tl/langtools/test/tools/javac/FloatingPointChanges/BadConstructorModifiers.sh DONE tl/langtools/test/tools/javac/ExtendsAccess/ExtendsAccess.sh DONE tl/langtools/test/tools/javac/NestedInnerClassNames.sh DONE tl/langtools/test/tools/javac/LocalClasses_2.sh DONE tl/langtools/test/tools/javac/NonStaticFieldExpr1.sh DONE tl/langtools/test/tools/javac/NameCollision.sh DONE These 3 were not done because they are not directly suitable for jtreg golden file tests: tl/langtools/test/tools/javac/4846262/Test.sh NOT DONE tl/langtools/test/tools/javac/fatalErrors/NoJavaLang.sh NOT DONE tl/langtools/test/tools/javac/6302184/T6302184.sh NOT DONE
10-07-2008

EVALUATION Rewrite tests to use jtreg /ref= mechanism.
09-07-2008