United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: JDK-6697238 missing dependencies for precompiled headers with platform dependent includes
JDK-6697238 : missing dependencies for precompiled headers with platform dependent includes

Details
Type:
Bug
Submit Date:
2008-05-02
Status:
Resolved
Updated Date:
2010-04-02
Project Name:
JDK
Resolved Date:
2008-07-03
Component:
hotspot
OS:
solaris_9
Sub-Component:
compiler
CPU:
sparc
Priority:
P4
Resolution:
Fixed
Affected Versions:
hs13
Fixed Versions:
hs14 (b01)

Related Reports
Backport:
Backport:

Sub Tasks

Description
MakeDeps generates dependencies for when to rebuild the precompiled headers but doesn't properly take into account the platform dependent includes which are directly included by some of the platform independent files.  The includes are of the form:


  // Platform specifics                                                                                                              
  #include "incls/_templateTable_pd.hpp.incl"

Currently if you modify the platform dependent include and do an incremental build it won't rebuild the precompiled headers which can result in compilation problems like this where it seems to both know about and no know about a newly added method:

/net/smite/export/ws/fused/src/cpu/x86/vm/templateTable_x86_64.cpp:510: error: no ?void TemplateTable::string_index_check(RegisterImpl*, RegisterImpl*)? member function declared in class ?TemplateTable?
/net/smite/export/ws/fused/src/cpu/x86/vm/templateTable_x86_64.cpp: In static member function ?static void TemplateTable::scstore()?:
/net/smite/export/ws/fused/src/cpu/x86/vm/templateTable_x86_64.cpp:963: error: cannot call member function ?void TemplateTable::string_index_check(RegisterImpl*, RegisterImpl*)? without object

                                    

Comments
EVALUATION

The platform dependent files should be collected and emitted when the main file is emitted in the dependencies.
                                     
2008-05-02
SUGGESTED FIX

http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/8b48a7bd2bf7
                                     
2008-06-17



Hardware and Software, Engineered to Work Together