United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: JDK-6617011 additional changes needed for new PIP FilesInUse dialog
JDK-6617011 : additional changes needed for new PIP FilesInUse dialog

Details
Type:
Bug
Submit Date:
2007-10-15
Status:
Closed
Updated Date:
2010-09-17
Project Name:
JDK
Resolved Date:
2008-03-24
Component:
install
OS:
generic,windows_xp
Sub-Component:
install
CPU:
x86,generic
Priority:
P3
Resolution:
Fixed
Affected Versions:
6u5
Fixed Versions:
6u10 (b13)

Related Reports
Backport:

Sub Tasks

Description
6593761 is now completed, and the FilesInUse Dialog is working properly.  However, there are a few items that still need to be implemented:

-The listbox will have an all white background, rather than alternate shading.
-There is no i18n/l10n at this point.  It's all English for b06.
-It will show the .exe name, rather than the name of the actual application.
-ListBox items should not be selectable.

We'll need to address this in a later 6uN build.

http://xdesign.sfbay/projects/java/j2se/consumer/PatchInPlace/PatchInPlace.html#212
Also, "Quit the applications listed" is checked by default.

The spec does say unchecked:
http://xdesign.sfbay/projects/java/j2se/consumer/PatchInPlace/PatchInPlace.html#212

Bill says it should be just a 1 line change.
Webrev/test cases are out and accepted for the required code changes.  In addition to the enhancements listed in this CR, the changes also:

1. Introduced a horizontal scroll bar in the event window titles exceed the real estate provided in the listbox (scaled dynamically).
2. Added sorting to listbox contents (alphabetical).
webrev: http://sa.sfbay.sun.com/projects/deployment_data/6u10/6617011.1

                                    

Comments
EVALUATION

Here's what needed to be done:

1. The listbox should have alternate shading for items.
2. i18n work needs to be done
3. It should show the name of the actual application, rather than the .exe name
4. ListBox items should not be selectable.

We've decided that #1 is not necessary, because the items are not selectable anyways.  Rajani already implemented #2 with her fix for 6612115.

So all that needs to be done is #3 and #4.  I believe #4 just involves using LBS_NOSEL for the listbox control in jinstall.rc.
                                     
2007-10-17
EVALUATION

There are now 3 things that need to be done for this bug:

1. It should show the name of the actual application, rather than the .exe name.  This should be retrieved from either the title of the dialog of the application, or the ProductName of the dll/exe that is running the process.  We should go with the industry standard, whatever that is. 

2. The ListBox items should not be selectable.  This just involves using LBS_NOSEL for the listbox control in jinstall.rc.

3. The checkbox should be unchecked by default, rather than checked.  This just involves removing these 2 lines from deploy/src/plugin/win32/jinstall/win32/FilesInUse.cpp:

   //make sure checkbox is checked by default
   CheckDlgButton(IDC_FILESINUSE_CHECKBOX, BST_CHECKED);
                                     
2007-11-28
EVALUATION

If the locked executable name is either jusched.exe or jucheck.exe, we should just ignore it and not show it in the ListBox...and let the user continue.  These are known java update processes, that the next update msi will automatically shutdown.
                                     
2007-12-04
EVALUATION

There was another CR that got piggy-backed onto this one regarding jusched and jucheck (see above).  This is the reason this CR failed during verification.

Instead of re-opening the CR that was closed as a duplicate of this one, I'll just fix the jusched and jucheck issue along with the other enhancements already implemented.
                                     
2008-03-03
EVALUATION

Upon further review it makes sense to re-open the jusched/jucheck CR, and re-evaluate this one for the original enhancements.

The jusched/jucheck CR will be addressed in b14.
                                     
2008-03-03



Hardware and Software, Engineered to Work Together