JDK-6570749 : sun.awt.im.InputMethodPopupMenu should be the same in 6u3 and 7
Type:Enhancement
Component:client-libs
Sub-Component:javax.swing
Affected Version:7
Priority:P5
Status:Resolved
Resolution:Fixed
OS:generic
CPU:generic
Submitted:2007-06-18
Updated:2011-01-19
Resolved:2007-09-12
The Version table provides details related to the release that this issue/RFE will be addressed.
Unresolved : Release in which this issue/RFE will be addressed. Resolved: Release in which this issue/RFE has been resolved. Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.
In 6u3 the fix for 6544309 rolls back changes of the fix for 6492266 in InputMethodPopupMenu, but in 7 it doesn't. InputMethodPopupMenu should be the same in 6u3 and 7.
Comments
SUGGESTED FIX
Webrev: http://javaweb.sfbay/jcg/7/swing/6570749/
Fix:
+++ InputMethodPopupMenu.java Mon Jun 18 20:07:22 2007
@@ -169,13 +169,10 @@
JInputMethodPopupMenu(String title) {
synchronized (this) {
if (delegate == null) {
delegate = new JPopupMenu(title);
- // To ensure that popup menu will work with proper AppContext
- // we should make it heavyweight. See 6492266.
- delegate.setLightWeightPopupEnabled(false);
}
}
}
void show(Component c, int x, int y) {
@@ -192,15 +189,11 @@
void addToComponent(Component c) {
}
Object createSubmenu(String label) {
- JMenu menu = new JMenu(label);
- // To ensure that popup menu will work with proper AppContext
- // we should make it heavyweight. See 6492266.
- menu.getPopupMenu().setLightWeightPopupEnabled(false);
- return menu;
+ return new JMenu(label);
}
void add(Object menuItem) {
delegate.add((JMenuItem)menuItem);
}
19-06-2007
EVALUATION
Simply InputMethodPopupMenu changes should be taken from this webrev: http://sa.sfbay.sun.com/projects/swing_data/6u3/6544309/