JDK-6364793 : Add missing @since 1.6 in Core Library javadoc
  • Type: Bug
  • Component: other-libs
  • Sub-Component: other
  • Affected Version: 5.0
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • OS: linux
  • CPU: x86
  • Submitted: 2005-12-19
  • Updated: 2010-04-03
  • Resolved: 2006-01-07
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 6
6 b67Fixed
Related Reports
Relates :  
JDK-6207928 - ReentrantReadWriteLock provides no way to tell if current thread holds read lock
Relates :  
JDK-6213423 - (spec) Missing @since 1.5 tag from java.lang.Iterable
Relates :  
JDK-6367207 - Ensure correctness of all @since tags added since 1.2
Description
ReentrantReadWriteLock.getReadHoldCount() was apparently added as part of bug #6207928 for Mustang (thank you! much needed) but seems to lack a @since 1.6 tag in the Javadoc.
Comments
SUGGESTED FIX --- /u/martin/ws/mustang/src/share/classes/java/io/File.java 2005-12-04 14:53:16.934959000 -0800 +++ /u/martin/ws/since/src/share/classes/java/io/File.java 2005-12-20 20:04:36.440300000 -0800 @@ -1495,6 +1495,8 @@ * If a security manager exists and its <code>{@link * java.lang.SecurityManager#checkExec(java.lang.String)}</code> * method denies read access to the file + * + * @since 1.6 */ public boolean canExecute() { SecurityManager security = System.getSecurityManager(); --- /u/martin/ws/mustang/src/share/classes/java/nio/Buffer.java 2005-12-04 14:53:56.800383000 -0800 +++ /u/martin/ws/since/src/share/classes/java/nio/Buffer.java 2005-12-20 20:09:38.072447000 -0800 @@ -393,6 +393,8 @@ * * @return <tt>true</tt> if, and only if, this buffer * is backed by an array and is not read-only + * + * @since 1.6 */ public abstract boolean hasArray(); @@ -418,6 +420,8 @@ * * @throws UnsupportedOperationException * If this buffer is not backed by an accessible array + * + * @since 1.6 */ public abstract Object array(); @@ -440,6 +444,8 @@ * * @throws UnsupportedOperationException * If this buffer is not backed by an accessible array + * + * @since 1.6 */ public abstract int arrayOffset(); @@ -448,6 +454,8 @@ * <a href="ByteBuffer.html#direct"><i>direct</i></a>. </p> * * @return <tt>true</tt> if, and only if, this buffer is direct + * + * @since 1.6 */ public abstract boolean isDirect(); --- /u/martin/ws/mustang/src/share/classes/java/util/LinkedList.java 2005-12-04 14:54:55.249370000 -0800 +++ /u/martin/ws/since/src/share/classes/java/util/LinkedList.java 2005-12-20 19:41:54.963720000 -0800 @@ -798,6 +798,9 @@ return result; } + /** + * @since 1.6 + */ public Iterator<E> descendingIterator() { return new DescendingIterator(); } --- /u/martin/ws/mustang/src/share/classes/java/util/concurrent/locks/ReentrantReadWriteLock.java 2005-12-04 14:55:12.093833000 -0800 +++ /u/martin/ws/since/src/share/classes/java/util/concurrent/locks/ReentrantReadWriteLock.java 2005-12-20 19:43:53.024463000 -0800 @@ -1122,6 +1122,7 @@ * * @return the number of holds on the read lock by the current thread, * or zero if the read lock is not held by the current thread. + * @since 1.6 */ public int getReadHoldCount() { return sync.getReadHoldCount();
21-12-2005
EVALUATION I dusted off my old tool sinceCheck and used it to find more missing @since (see Suggested Fix)
20-12-2005