JDK-4297981 : Sequencer, DataLine state query methods require name change
  • Type: Enhancement
  • Component: client-libs
  • Sub-Component: javax.sound
  • Affected Version: 1.3.0
  • Priority: P2
  • Status: Resolved
  • Resolution: Fixed
  • OS: generic
  • CPU: generic
  • Submitted: 1999-12-09
  • Updated: 1999-12-18
  • Resolved: 1999-12-18
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
1.3.0 kestrelFixed
Related Reports
Relates :  
JDK-4791152 - SPEC: description of isRunning(), isActive() is incomplete
Description
The isRunning() method on the DataLine and Sequencer interfaces 
should be renamed to isStarted().

Both of these interfaces have methods called start() and stop(),
and DataLine generates START and STOP events.  For naming
consistency, the method used to query the start/stop state
should be called "isStarted()".
Comments
CONVERTED DATA BugTraq+ Release Management Values COMMIT TO FIX: kestrel FIXED IN: kestrel INTEGRATED IN: kestrel
14-06-2004
SUGGESTED FIX Proposed API change: Rename the following two methods: In javax.sound.sampled.DataLine: old: public boolean isRunning() new: public boolean isStarted() In javax.sound.midi.Sequencer: old: public boolean isRunning() new: public boolean isStarted()
11-06-2004
EVALUATION I agree with the proposed fix, and have already made these changes. Both of these changes involve renaming the methods in the interface classes under javax.sound, and making the equivalent change to our implementation classes. These methods are not referenced internally to our implementation, so no additional code changes are required. Note that the method change in DataLine was made several weeks ago and has already appeared in the promoted builds. Reversing this change would require additional code changes and introduce additional risk. In addition, DataLine.isStarted() matches the method name in the Kestrel beta release. ###@###.### 1999-12-08 Denied by CCC on 12-09-1999. I have backed out Sequencer.isStarted() for our integration with VM on 12-10-1999. I will back out DataLine.isStarted() and work with Roger Calnan on getting this integrated for build R. ###@###.### 1999-12-09 ----- This change request for kestrel was denied by the CCC. The name isRunning() will be maintained for both Sequencer and DataLine. This change will not be made. We will make the necessary changes to back out the name change. kara.kytle@Eng 1999-12-13
13-12-1999